Issue 4634124: code review 4634124: gc: make size of struct{} and [0]byte 0 bytes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4634124: code review 4634124: gc: make size of struct{} and [0]byte 0 bytes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by rh

Modified:
13 years, 4 months ago

Reviewers:

CC:
iant, rsc, golang-dev

Visibility:
Public.

Description

gc: make size of struct{} and [0]byte 0 bytes Fixes issue 1949.

Patch Set 1 #

Patch Set 2 : diff -r 7ce1c776ff33 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7ce1c776ff33 https://go.googlecode.com/hg/ #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -20 lines)			Patch
	M	src/cmd/gc/align.c	View	1	3 chunks	+8 lines, -19 lines	0 comments	Download
	M	src/cmd/gc/pgen.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 4 months ago (2011-07-02 15:18:57 UTC) #1

iant2

robert.hencke@gmail.com writes: > gc: make size of struct{} and [0]byte 0 bytes > > Fixes ...

13 years, 4 months ago (2011-07-03 04:21:37 UTC) #2

On 2011/07/03 04:21:37, iant2 wrote: > Does this whole tree build and pass tests with ...

13 years, 4 months ago (2011-07-03 16:47:32 UTC) #3

rsc

13 years, 4 months ago (2011-07-12 18:12:08 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=6e4ee32fffd1 ***

gc: make size of struct{} and [0]byte 0 bytes

Fixes issue 1949.

R=iant, rsc
CC=golang-dev
http://codereview.appspot.com/4634124

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages