Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(287)

Issue 4634112: code review 4634112: http: make NewChunkedReader public (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by andybalholm
Modified:
13 years, 8 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

http: make NewChunkedReader public

Patch Set 1 #

Patch Set 2 : diff -r e93aca7ce587 https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 3 : diff -r e93aca7ce587 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M src/pkg/http/chunked.go View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M src/pkg/http/request.go View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/pkg/http/transfer.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7
andybalholm
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-06-29 17:53:35 UTC) #1
bradfitz
You'll need to submit a CLA first. See the bottom of http://golang.org/doc/contribute.html On Wed, Jun ...
13 years, 8 months ago (2011-06-29 17:58:08 UTC) #2
andybalholm
On Jun 29, 2011, at 10:57 AM, Brad Fitzpatrick wrote: > You'll need to submit ...
13 years, 8 months ago (2011-06-29 18:05:35 UTC) #3
bradfitz
No past tense in the subject, and no need for a trailing period. Make it: ...
13 years, 8 months ago (2011-06-29 19:02:45 UTC) #4
andybalholm
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 8 months ago (2011-06-29 19:16:39 UTC) #5
bradfitz
LGTM On Wed, Jun 29, 2011 at 12:16 PM, <andybalholm@gmail.com> wrote: > Hello golang-dev@googlegroups.com, bradfitz@golang.org ...
13 years, 8 months ago (2011-06-29 19:23:13 UTC) #6
bradfitz
13 years, 8 months ago (2011-06-29 19:27:59 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=49afab7d8d33 ***

http: make NewChunkedReader public

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4634112

Committer: Brad Fitzpatrick <bradfitz@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b