code review 4634112: http: make NewChunkedReader public

http: make NewChunkedReader public

[andybalholm, 2011-06-29 17:53:35]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2011-06-29 17:58:08]

You'll need to submit a CLA first.

See the bottom of http://golang.org/doc/contribute.html

On Wed, Jun 29, 2011 at 10:53 AM, <andybalholm@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> http: made NewChunkedReader public.
>
> I also moved it from request.go to chunked.go.
>
> Please review this at
http://codereview.appspot.com/**4634112/<http://codereview.appspot.com/4634112/>
>
> Affected files:
>  M src/pkg/http/chunked.go
>  M src/pkg/http/request.go
>  M src/pkg/http/transfer.go
>
>
>

[andybalholm, 2011-06-29 18:05:35]

On Jun 29, 2011, at 10:57 AM, Brad Fitzpatrick wrote:

> You'll need to submit a CLA first.

OK. I've done that now.

[bradfitz, 2011-06-29 19:02:45]

No past tense in the subject, and no need for a trailing period.  Make it:

"http: make NewChunkedReader public"

Also, we try to minimize unrelated changes in single CLs & keep the diffs small
& readable.  A clean-up or moving stuff around can happen in a subsequent CL.

Why don't you just move the 3-line newChunkedReader -> NewChunkedWriter to
chunked.go, but keep the rest of the stuff in request.go.

http://codereview.appspot.com/4634112/diff/1001/src/pkg/http/chunked.go
File src/pkg/http/chunked.go (right):

http://codereview.appspot.com/4634112/diff/1001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:70: // out of HTTP "chunked" format before returning it.
When it reads the final
The reader returns os.EOF when the final 0-length chunk is read.

http://codereview.appspot.com/4634112/diff/1001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:74: // adds chunking automatically if the request has a
Transfer-Encoding: chunked
Let's simplify this to just two sentences:

"NewChunkedReader is not needed by normal applications. The http package
automatically decodes chunking when reading response bodies."

[andybalholm, 2011-06-29 19:16:39]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2011-06-29 19:23:13]

LGTM

On Wed, Jun 29, 2011 at 12:16 PM, <andybalholm@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
http://codereview.appspot.com/**4634112/<http://codereview.appspot.com/4634112/>
>

[bradfitz, 2011-06-29 19:27:59]

*** Submitted as http://code.google.com/p/go/source/detail?r=49afab7d8d33 ***

http: make NewChunkedReader public

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4634112

Committer: Brad Fitzpatrick <bradfitz@golang.org>