code review 4634073: gc: Escape analysis.

src/cmd/gc/typecheck.c

 // Copyright 2009 The Go Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 /*
  * type check the whole tree of an expression.
  * calculates expression types.
  * evaluates compile time constants.
  * marks variables that escape the local frame.
  * rewrites n->op to be more specific in some cases.
@@ skipping 1023 matching lines @@
                 n->type = types[TINT];
                 typecheck(&n->left, Erv);
                 typecheck(&n->right, Erv);
                 if(n->left->type == T || n->right->type == T)
                         goto error;
                 defaultlit(&n->left, T);
                 defaultlit(&n->right, T);
 ················
                 // copy([]byte, string)
                 if(isslice(n->left->type) && n->right->type->etype == TSTRING) {
-                        if (n->left->type->type == types[TUINT8])
+                        if(n->left->type->type == types[TUINT8])
                                 goto ret;
                         yyerror("arguments to copy have different element types: %lT and string", n->left->type);
                         goto error;
                 }
 ·······························
                 if(!isslice(n->left->type) || !isslice(n->right->type)) {
                         if(!isslice(n->left->type) && !isslice(n->right->type))
                                 yyerror("arguments to copy must be slices; have %lT, %lT", n->left->type, n->right->type);
                         else if(!isslice(n->left->type))
                                 yyerror("first argument to copy should be slice; have %lT", n->left->type);
@@ skipping 543 matching lines @@
                 return 1;
         }
 
         if(f2 != T) {
                 tt = n->left->type;
                 dowidth(tt);
                 rcvr = getthisx(f2->type)->type->type;
                 if(!eqtype(rcvr, tt)) {
                         if(rcvr->etype == tptr && eqtype(rcvr->type, tt)) {
                                 checklvalue(n->left, "call pointer method on");
-                                if (!debug['s'])

[rsc, 2011/08/24 14:27:46]

s/if (/if(/

[lvd, 2011/08/24 16:51:40]

Done.

+                                if(!debug['s'])
                                         addrescapes(n->left);
                                 n->left = nod(OADDR, n->left, N);
                                 n->left->implicit = 1;
                                 typecheck(&n->left, Etype|Erv);
                         } else if(tt->etype == tptr && eqtype(tt->type, rcvr)) {
                                 n->left = nod(OIND, n->left, N);
                                 n->left->implicit = 1;
                                 typecheck(&n->left, Etype|Erv);
                         } else {
                                 // method is attached to wrong type?
@@ skipping 1127 matching lines @@
 ret:
         if(typecheckdefstack->n != n)
                 fatal("typecheckdefstack mismatch");
         l = typecheckdefstack;
         typecheckdefstack = l->next;
 
         lineno = lno;
         n->walkdef = 1;
         return n;
 }