Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 4631098: code review 4631098: sort: rename helpers: s/Sort// in sort.Sort[Float64s|In... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by adg
Modified:
11 years, 7 months ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

sort: rename helpers: s/Sort// in sort.Sort[Float64s|Ints|Strings] Includes 'sorthelpers' gofix and updates to tree.

Patch Set 1 #

Patch Set 2 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 6998f26de587 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r d912d3d2954b https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r e276ba524959 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -33 lines) Patch
M src/cmd/godoc/codewalk.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/index.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/mapping.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/godoc/utils.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gofix/Makefile View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/cmd/gofix/sorthelpers.go View 1 2 1 chunk +47 lines, -0 lines 0 comments Download
A src/cmd/gofix/sorthelpers_test.go View 1 2 1 chunk +45 lines, -0 lines 0 comments Download
M src/cmd/hgpatch/main.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/exp/template/exec_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/go/doc/doc.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/http/header.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/index/suffixarray/suffixarray.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/index/suffixarray/suffixarray_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/net/hosts_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/path/filepath/match.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/sort/sort.go View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/pkg/sort/sort_test.go View 1 2 3 4 5 6 chunks +12 lines, -12 lines 0 comments Download
M src/pkg/time/sleep_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/unicode/maketables.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 7 months ago (2011-07-08 00:13:42 UTC) #1
gri
LGTM
11 years, 7 months ago (2011-07-08 00:22:33 UTC) #2
adg
11 years, 7 months ago (2011-07-08 00:52:56 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=828e19cf4237 ***

sort: rename helpers: s/Sort// in sort.Sort[Float64s|Ints|Strings]

Includes 'sorthelpers' gofix and updates to tree.

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/4631098
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b