code review 4629070: cmd/cc/, cmd/8c/: Adjustments for compilation on Plan 9...

cmd/cc/, cmd/8c/: Adjustments for compilation on Plan 9 native platforms

8c/gc.h:
. Added <u.h> header.
. Added "lD" pragma for "*Adr" to supplement "D".

8c/swt.c:
. Removed unreferenced "thestring" arguments in Bprint() calls.

cc/acid.c:
cc/com.c:
cc/com64.c:
cc/dcl.c:
cc/scon.c:
. Added <u.h>, required by "cc.h".

cc/bits.c:
. Added <u.h>, required by "cc.h".

cc/cc.h:
. Removed <u.h> and <ctype.h>.
. Added "O" pragma to accept "uint" as well as "int".
. Added new "U" pragma (char *).

cc/cc.y:
. Added <u.h> before <stdio.h> (and "cc.h").

cc/dpchk.c:
cc/mac.c:
. Added <u.h> and <ctype.h>.

cc/funct.c:
. Added <u.h>, required by "cc.h".

cc/godefs.c
. Added <u.h>, required by "cc.h".
. Dropped unused "t" argument in Bprint().

cc/lex.c:
. Added <u.h> and <ctype.h>.
. Removed unnecessary incrementation.
. Changed exit() invocations with exits().

cc/omachcap.c:
. Added <u.h>, required by "cc.h".
. USED(n) for unused argument to machcap().

cc/sub.c:
. Added <u.h> and <ctype.h>.

[lucio, 2011-06-24 19:07:11]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
rsc@golang.org),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2011-06-27 20:10:01]

Every change we make to these files shows up as
a diff when people compare them to the Inferno or
Plan 9 copies.  Before making a change ask yourself
"do I have to do this to make it build or make it correct?"

There are some necessary changes here (the new
#include lines, mainly) but they are lost among the
unnecessary changes.

http://codereview.appspot.com/4629070/diff/5001/src/cmd/8c/cgen.c
File src/cmd/8c/cgen.c (right):

http://codereview.appspot.com/4629070/diff/5001/src/cmd/8c/cgen.c#newcode41
src/cmd/8c/cgen.c:41: uint o;
Why?  Remember that the u flag does not require an
unsigned argument, nor does an unsigned argument
require the u flag.  This looks like a gratuitous change.
Also note that this is a change from Plan 9's
/sys/src/cmd/8c/gen.c.  Please revert this and all
the other uint-related changes.

http://codereview.appspot.com/4629070/diff/5001/src/cmd/8c/gc.h
File src/cmd/8c/gc.h (left):

http://codereview.appspot.com/4629070/diff/5001/src/cmd/8c/gc.h#oldcode31
src/cmd/8c/gc.h:31: #include	"../cc/cc.h"
Code you add should look like the code that's already there.
If it says #include<tab>, leave the tabs.
Please revert this and all the other tab-related changes.

[lucio, 2011-06-28 03:41:34]

On 6/27/11, rsc@golang.org <rsc@golang.org> wrote:
> Every change we make to these files shows up as
> a diff when people compare them to the Inferno or
> Plan 9 copies.  Before making a change ask yourself
> "do I have to do this to make it build or make it correct?"
>
> There are some necessary changes here (the new
> #include lines, mainly) but they are lost among the
> unnecessary changes.
>
I understand the motivation, but in my defence I thought using a more
uniform approach would be a long-term improvement.

I'll revert the tab changes, the formatting changes will require me to
add a new varargck.  I'll leave the redefinition of "o" as a uint,
even if that means that it will take an extra cycle of inspection to
finalise the changes: I think that bit may seem gratuitous, but it is
more accurate.

I don't mind the extra effort, I'm sorry if it creates more difficulty for you.

Lucio.

[rsc, 2011-06-28 04:33:41]

> I'll leave the redefinition of "o" as a uint,
> even if that means that it will take an extra cycle of inspection to
> finalise the changes: I think that bit may seem gratuitous, but it is
> more accurate.

It's still gratuitous.  Please revert it.

Russ

[lucio, 2011-06-29 05:15:25]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[lucio, 2011-06-29 05:23:53]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-07-01 13:32:49]

LGTM

Thanks for simplifying the changes.

[rsc, 2011-07-01 13:50:30]

*** Submitted as http://code.google.com/p/go/source/detail?r=4da526e7b4cb ***

8c: fixes for Plan 9 build

8c/gc.h:
. Added <u.h> header.
. Added "lD" pragma for "*Adr" to supplement "D".

8c/swt.c:
. Removed unreferenced "thestring" arguments in Bprint() calls.

cc/acid.c:
cc/com.c:
cc/com64.c:
cc/dcl.c:
cc/scon.c:
. Added <u.h>, required by "cc.h".

cc/bits.c:
. Added <u.h>, required by "cc.h".

cc/cc.h:
. Removed <u.h> and <ctype.h>.
. Added "O" pragma to accept "uint" as well as "int".
. Added new "U" pragma (char *).

cc/cc.y:
. Added <u.h> before <stdio.h> (and "cc.h").

cc/dpchk.c:
cc/mac.c:
. Added <u.h> and <ctype.h>.

cc/funct.c:
. Added <u.h>, required by "cc.h".

cc/godefs.c
. Added <u.h>, required by "cc.h".
. Dropped unused "t" argument in Bprint().

cc/lex.c:
. Added <u.h> and <ctype.h>.
. Removed unnecessary incrementation.
. Changed exit() invocations with exits().

cc/omachcap.c:
. Added <u.h>, required by "cc.h".
. USED(n) for unused argument to machcap().

cc/sub.c:
. Added <u.h> and <ctype.h>.

R=rsc
CC=golang-dev
http://codereview.appspot.com/4629070

Committer: Russ Cox <rsc@golang.org>