Issue 4627084: code review 4627084: crypto/openpgp: add ability to reserialize keys.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4627084: code review 4627084: crypto/openpgp: add ability to reserialize keys. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by agl1

Modified:
13 years, 8 months ago

Reviewers:

CC:
bradfitz, golang-dev

Visibility:
Public.

Description

crypto/openpgp: add ability to reserialize keys. This changes Signature so that parsed signatures can be reserialized exactly. With this ability we can add Serialize to Entity and also the ability to sign other public keys.

Patch Set 1 #

Patch Set 2 : diff -r 01c00d744ba3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 01c00d744ba3 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 4 : diff -r 620afc45f351 https://go.googlecode.com/hg/ #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+150 lines, -34 lines)			Patch
M	src/pkg/crypto/openpgp/keys.go	View	1 2 3	2 chunks	+67 lines, -0 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/public_key.go	View	1	2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/signature.go	View	1	13 chunks	+35 lines, -27 lines	0 comments	Download
M	src/pkg/crypto/openpgp/packet/signature_test.go	View	1	2 chunks	+18 lines, -4 lines	0 comments	Download
M	src/pkg/crypto/openpgp/read_test.go	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

agl1

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-01 16:55:29 UTC) #1

bradfitz

LGTM http://codereview.appspot.com/4627084/diff/5001/src/pkg/crypto/openpgp/keys.go File src/pkg/crypto/openpgp/keys.go (right): http://codereview.appspot.com/4627084/diff/5001/src/pkg/crypto/openpgp/keys.go#newcode481 src/pkg/crypto/openpgp/keys.go:481: // Serialize serializes the public part of the ...

13 years, 8 months ago (2011-07-01 17:16:51 UTC) #2

agl1

13 years, 8 months ago (2011-07-01 17:53:50 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=13ec466f6670 ***

crypto/openpgp: add ability to reserialize keys.

This changes Signature so that parsed signatures can be reserialized
exactly. With this ability we can add Serialize to Entity and also the
ability to sign other public keys.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/4627084

http://codereview.appspot.com/4627084/diff/5001/src/pkg/crypto/openpgp/keys.go
File src/pkg/crypto/openpgp/keys.go (right):

http://codereview.appspot.com/4627084/diff/5001/src/pkg/crypto/openpgp/keys.g...
src/pkg/crypto/openpgp/keys.go:481: // Serialize serializes the public part of
the given Entity to w. (No private
On 2011/07/01 17:16:51, bradfitz wrote:
> Serialize writes?

Done.

http://codereview.appspot.com/4627084/diff/5001/src/pkg/crypto/openpgp/keys.g...
src/pkg/crypto/openpgp/keys.go:518: // associated with e. identity must already
be an element of e.Identities and
On 2011/07/01 17:16:51, bradfitz wrote:
> Starting a sentence with a lowercase identifier is a bit weird, especially
after
> a sentence ending with a non-word lowercase identifier. "The provided
identity"?

Done.

Expand All Messages | Collapse All Messages