code review 4627081: dashboard: show build state and package comments on das...

dashboard: show build state and package comments on dashboard

This permits full URLs to be shown on the dashboard,
not just the repository roots.

This has been tested.

[adg, 2011-07-01 06:24:20]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-07-01 06:27:39]

http://codereview.appspot.com/4627081/diff/1/misc/dashboard/builder/main.go
File misc/dashboard/builder/main.go (right):

http://codereview.appspot.com/4627081/diff/1/misc/dashboard/builder/main.go#n...
misc/dashboard/builder/main.go:595: if len(s) != 40 {
This is vexing. It shouldn't have worked at all before, but clearly it is. Why?
Is it because of my Mercurial version (1.8)?

[mattn, 2011-07-01 06:52:56]

LGTM except 1 thing.

http://codereview.appspot.com/4627081/diff/1/misc/dashboard/godashboard/packa...
File misc/dashboard/godashboard/package.py (right):

http://codereview.appspot.com/4627081/diff/1/misc/dashboard/godashboard/packa...
misc/dashboard/godashboard/package.py:187: p.info = self.request.get('info')
I think, it shouldn't pass from client request.
For example, someone overwrite the package information.

$ curl -d ok=true -d info="This package has critical bug. please don't install"
-d path=github.com/mattn/go-gtk/glib http://godashboard.appspot.com/package

[adg, 2011-07-01 07:10:29]

On 1 July 2011 16:52,  <mattn.jp@gmail.com> wrote:
>
http://codereview.appspot.com/4627081/diff/1/misc/dashboard/godashboard/packa...
> misc/dashboard/godashboard/package.py:187: p.info =
> self.request.get('info')
> I think, it shouldn't pass from client request.
> For example, someone overwrite the package information.
>
> $ curl -d ok=true -d info="This package has critical bug. please don't
> install" -d path=github.com/mattn/go-gtk/glib
> http://godashboard.appspot.com/package

You need to be an authenticated builder to update build state or
package info. (that's the call to auth on the preceding line).

Andrew

[mattn, 2011-07-01 07:20:11]

LGTM

On 2011/07/01 07:10:29, adg wrote:
> On 1 July 2011 16:52,  <mailto:mattn.jp@gmail.com> wrote:
> >
>
http://codereview.appspot.com/4627081/diff/1/misc/dashboard/godashboard/packa...
> > misc/dashboard/godashboard/package.py:187: p.info =
> > self.request.get('info')
> > I think, it shouldn't pass from client request.
> > For example, someone overwrite the package information.
> >
> > $ curl -d ok=true -d info="This package has critical bug. please don't
> > install" -d path=github.com/mattn/go-gtk/glib
> > http://godashboard.appspot.com/package
> 
> You need to be an authenticated builder to update build state or
> package info. (that's the call to auth on the preceding line).
> 
> Andrew

[rsc, 2011-07-01 14:28:23]

LGTM

http://codereview.appspot.com/4627081/diff/2001/misc/dashboard/godashboard/st...
File misc/dashboard/godashboard/static/style.css (right):

http://codereview.appspot.com/4627081/diff/2001/misc/dashboard/godashboard/st...
misc/dashboard/godashboard/static/style.css:62: td.date { color: #aaa; }
can you make these look like all the others in the file please?

[adg, 2011-07-02 04:02:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=194ca0d677c7 ***

dashboard: show build state and package comments on dashboard

This permits full URLs to be shown on the dashboard,
not just the repository roots.

This has been tested.

R=rsc, mattn.jp
CC=golang-dev
http://codereview.appspot.com/4627081

http://codereview.appspot.com/4627081/diff/2001/misc/dashboard/godashboard/st...
File misc/dashboard/godashboard/static/style.css (right):

http://codereview.appspot.com/4627081/diff/2001/misc/dashboard/godashboard/st...
misc/dashboard/godashboard/static/style.css:62: td.date { color: #aaa; }
On 2011/07/01 14:28:23, rsc wrote:
> can you make these look like all the others in the file please?

Done.