Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Side by Side Diff: gcc/passes.c

Issue 4626099: [pph] Add FIXME comment to avoid finalizing decls when generating pph image. (Closed)
Patch Set: Created 13 years, 9 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gcc/ChangeLog.pph ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* Top level of GCC compilers (cc1, cc1plus, etc.) 1 /* Top level of GCC compilers (cc1, cc1plus, etc.)
2 Copyright (C) 1987, 1988, 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998, 2 Copyright (C) 1987, 1988, 1989, 1992, 1993, 1994, 1995, 1996, 1997, 1998,
3 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 3 1999, 2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
4 Free Software Foundation, Inc. 4 Free Software Foundation, Inc.
5 5
6 This file is part of GCC. 6 This file is part of GCC.
7 7
8 GCC is free software; you can redistribute it and/or modify it under 8 GCC is free software; you can redistribute it and/or modify it under
9 the terms of the GNU General Public License as published by the Free 9 the terms of the GNU General Public License as published by the Free
10 Software Foundation; either version 3, or (at your option) any later 10 Software Foundation; either version 3, or (at your option) any later
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 177
178 We do output all variables and rely on 178 We do output all variables and rely on
179 callgraph code to defer them except for forward declarations 179 callgraph code to defer them except for forward declarations
180 (see gcc.c-torture/compile/920624-1.c) */ 180 (see gcc.c-torture/compile/920624-1.c) */
181 if ((at_end 181 if ((at_end
182 || !DECL_DEFER_OUTPUT (decl) 182 || !DECL_DEFER_OUTPUT (decl)
183 || DECL_INITIAL (decl)) 183 || DECL_INITIAL (decl))
184 && !DECL_EXTERNAL (decl)) 184 && !DECL_EXTERNAL (decl))
185 { 185 {
186 /* When reading LTO unit, we also read varpool, so do not 186 /* When reading LTO unit, we also read varpool, so do not
187 » rebuild it. */ 187 » rebuild it.
188 » FIXME pph: This is also true for pph and we should not
189 » call varpool_finalize_decl when generating a pph image. */
188 if (in_lto_p && !at_end) 190 if (in_lto_p && !at_end)
189 ; 191 ;
190 else if (TREE_CODE (decl) != FUNCTION_DECL) 192 else if (TREE_CODE (decl) != FUNCTION_DECL)
191 varpool_finalize_decl (decl); 193 varpool_finalize_decl (decl);
192 } 194 }
193 195
194 #ifdef ASM_FINISH_DECLARE_OBJECT 196 #ifdef ASM_FINISH_DECLARE_OBJECT
195 if (decl == last_assemble_variable_decl) 197 if (decl == last_assemble_variable_decl)
196 { 198 {
197 ASM_FINISH_DECLARE_OBJECT (asm_out_file, decl, 199 ASM_FINISH_DECLARE_OBJECT (asm_out_file, decl,
(...skipping 2353 matching lines...) Expand 10 before | Expand all | Expand 10 after
2551 } 2553 }
2552 if (dump_file && e) 2554 if (dump_file && e)
2553 { 2555 {
2554 fprintf (dump_file, "Already processed call to:\n"); 2556 fprintf (dump_file, "Already processed call to:\n");
2555 dump_cgraph_node (dump_file, e->caller); 2557 dump_cgraph_node (dump_file, e->caller);
2556 } 2558 }
2557 return e != NULL; 2559 return e != NULL;
2558 } 2560 }
2559 2561
2560 #include "gt-passes.h" 2562 #include "gt-passes.h"
OLDNEW
« no previous file with comments | « gcc/ChangeLog.pph ('k') | no next file » | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b