Issue 4626095: code review 4626095: exp/template: remove the need for a goroutine.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4626095: code review 4626095: exp/template: remove the need for a goroutine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by r

Modified:
13 years, 8 months ago

Reviewers:
dsymonds

CC:
golang-dev, adg

Visibility:
Public.

Description

exp/template: remove the need for a goroutine.

Patch Set 1 #

Patch Set 2 : diff -r 10dd6b381846 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -15 lines)			Patch
	M	src/pkg/exp/template/lex.go	View	1	2 chunks	+14 lines, -13 lines	0 comments	Download
	M	src/pkg/exp/template/lex_test.go	View	1	1 chunk	+7 lines, -2 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 8 months ago (2011-07-06 00:58:59 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=29f39dfc874f *** exp/template: remove the need for a goroutine. R=golang-dev, adg CC=golang-dev ...

13 years, 8 months ago (2011-07-06 01:03:01 UTC) #3

dsymonds

13 years, 8 months ago (2011-07-06 01:03:09 UTC) #4

LGTM

http://codereview.appspot.com/4626095/diff/3001/src/pkg/exp/template/lex_test.go
File src/pkg/exp/template/lex_test.go (right):

http://codereview.appspot.com/4626095/diff/3001/src/pkg/exp/template/lex_test...
src/pkg/exp/template/lex_test.go:143: println(test.name)
dreg?

Expand All Messages | Collapse All Messages