Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(13)

Issue 4626095: code review 4626095: exp/template: remove the need for a goroutine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by r
Modified:
13 years, 8 months ago
Reviewers:
dsymonds
CC:
golang-dev, adg
Visibility:
Public.

Description

exp/template: remove the need for a goroutine.

Patch Set 1 #

Patch Set 2 : diff -r 10dd6b381846 https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M src/pkg/exp/template/lex.go View 1 2 chunks +14 lines, -13 lines 0 comments Download
M src/pkg/exp/template/lex_test.go View 1 1 chunk +7 lines, -2 lines 1 comment Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 8 months ago (2011-07-06 00:58:59 UTC) #1
adg
LGTM after gofmt
13 years, 8 months ago (2011-07-06 01:02:28 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=29f39dfc874f *** exp/template: remove the need for a goroutine. R=golang-dev, adg CC=golang-dev ...
13 years, 8 months ago (2011-07-06 01:03:01 UTC) #3
dsymonds
13 years, 8 months ago (2011-07-06 01:03:09 UTC) #4
LGTM

http://codereview.appspot.com/4626095/diff/3001/src/pkg/exp/template/lex_test.go
File src/pkg/exp/template/lex_test.go (right):

http://codereview.appspot.com/4626095/diff/3001/src/pkg/exp/template/lex_test...
src/pkg/exp/template/lex_test.go:143: println(test.name)
dreg?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b