code review 4626092: exp/template: add an html escaping function.

exp/template: add an html escaping function.

[r, 2011-07-05 05:24:28]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2011-07-05 05:25:18]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2011-07-05 05:29:32]

LGTM

http://codereview.appspot.com/4626092/diff/6001/src/pkg/exp/template/funcs.go
File src/pkg/exp/template/funcs.go (right):

http://codereview.appspot.com/4626092/diff/6001/src/pkg/exp/template/funcs.go...
src/pkg/exp/template/funcs.go:71: var (
This could be a map, simplifying the function below.

var htmlEscapes = map[byte][]byte{
  '"': []byte("""),
  ...
}

http://codereview.appspot.com/4626092/diff/6001/src/pkg/exp/template/funcs.go...
src/pkg/exp/template/funcs.go:120: var s string
you could hide this away in a named return value if you want.

[adg, 2011-07-05 05:54:09]

LGTM

[r, 2011-07-05 05:56:00]

Hello golang-dev@googlegroups.com, dsymonds@golang.org, adg@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2011-07-05 05:59:03]

*** Submitted as http://code.google.com/p/go/source/detail?r=100d7a103792 ***

exp/template: add an html escaping function.

R=golang-dev, dsymonds, adg
CC=golang-dev
http://codereview.appspot.com/4626092