code review 4625062: weekly.2011-06-23

weekly.2011-06-23

[adg, 2011-06-24 04:52:46]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[rh, 2011-06-24 04:56:50]

Is the new goto restriction worth calling out?

[adg, 2011-06-24 05:07:57]

Hello golang-dev@googlegroups.com, robert.hencke@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rh, 2011-06-24 05:09:26]

Also, os.ErrorString is no longer exported... worth calling out?

[rh, 2011-06-24 05:10:25]

On 2011/06/24 05:09:26, rh wrote:
> Also, os.ErrorString is no longer exported... worth calling out?

sorry :)

[adg, 2011-06-24 05:14:22]

On 24 June 2011 15:10,  <robert.hencke@gmail.com> wrote:
> On 2011/06/24 05:09:26, rh wrote:
>>
>> Also, os.ErrorString is no longer exported... worth calling out?
>
> sorry :)

Jeeze, don't know how I missed that one.

You're right

[adg, 2011-06-24 05:16:49]

Hello golang-dev@googlegroups.com, robert.hencke@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rh, 2011-06-24 05:19:45]

LGTM

I keep hoping to see the bike/shed package make it in there one of these times.

[r, 2011-06-24 05:46:21]

LGTM

[adg, 2011-06-24 06:04:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=541c445d6c13 ***

weekly.2011-06-23

R=golang-dev, robert.hencke, r
CC=golang-dev
http://codereview.appspot.com/4625062