Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(667)

Issue 4625062: code review 4625062: weekly.2011-06-23 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by adg
Modified:
10 years, 4 months ago
Reviewers:
CC:
golang-dev, rh, r
Visibility:
Public.

Description

weekly.2011-06-23

Patch Set 1 #

Patch Set 2 : diff -r f212ec68da3c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f212ec68da3c https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f212ec68da3c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 4fae10f46847 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M .hgtags View 1 1 chunk +0 lines, -1 line 0 comments Download
M doc/devel/weekly.html View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 10
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 4 months ago (2011-06-24 04:52:46 UTC) #1
rh
Is the new goto restriction worth calling out?
10 years, 4 months ago (2011-06-24 04:56:50 UTC) #2
adg
Hello golang-dev@googlegroups.com, robert.hencke@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 4 months ago (2011-06-24 05:07:57 UTC) #3
rh
Also, os.ErrorString is no longer exported... worth calling out?
10 years, 4 months ago (2011-06-24 05:09:26 UTC) #4
rh
On 2011/06/24 05:09:26, rh wrote: > Also, os.ErrorString is no longer exported... worth calling out? ...
10 years, 4 months ago (2011-06-24 05:10:25 UTC) #5
adg
On 24 June 2011 15:10, <robert.hencke@gmail.com> wrote: > On 2011/06/24 05:09:26, rh wrote: >> >> ...
10 years, 4 months ago (2011-06-24 05:14:22 UTC) #6
adg
Hello golang-dev@googlegroups.com, robert.hencke@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 4 months ago (2011-06-24 05:16:49 UTC) #7
rh
LGTM I keep hoping to see the bike/shed package make it in there one of ...
10 years, 4 months ago (2011-06-24 05:19:45 UTC) #8
r
LGTM
10 years, 4 months ago (2011-06-24 05:46:21 UTC) #9
adg
10 years, 4 months ago (2011-06-24 06:04:26 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=541c445d6c13 ***

weekly.2011-06-23

R=golang-dev, robert.hencke, r
CC=golang-dev
http://codereview.appspot.com/4625062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b