Issue 4612042: Adds the +1 button to the playground

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4612042: Adds the +1 button to the playground (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by Jasvir

Modified:
15 years, 4 months ago

Reviewers:
ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adds the +1 button to the playground @4502

Patch Set 1 #

Total comments: 1

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -8 lines)			Patch
M	src/com/google/caja/demos/playground/Playground.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/ui/PlaygroundUI.ui.xml	View	2 chunks	+15 lines, -8 lines	0 comments	Download
M	src/com/google/caja/demos/playground/client/ui/PlaygroundView.java	View	2 chunks	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ihab.awad

15 years, 4 months ago (2011-06-14 04:09:23 UTC) #2

lgtm

http://codereview.appspot.com/4612042/diff/1/src/com/google/caja/demos/playgr...
File src/com/google/caja/demos/playground/client/ui/PlaygroundView.java (right):

http://codereview.appspot.com/4612042/diff/1/src/com/google/caja/demos/playgr...
src/com/google/caja/demos/playground/client/ui/PlaygroundView.java:254:
$wnd.gapi.plusone.render("plusone",{size: "medium"});
Nit: space after comma. :)

Expand All Messages | Collapse All Messages