Issue 4610043: Modify RenderContext to allow easy subclassing.

Issue 4610043: Modify RenderContext to allow easy subclassing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by MikeSamuel

Modified:
15 years, 4 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Modify RenderContext to allow easy subclassing. #

Patch Set 3 : Modify RenderContext to allow easy subclassing. #

Total comments: 5

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -21 lines)			Patch
M	src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	src/com/google/caja/parser/html/Dom.java	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/com/google/caja/parser/js/CajoledModule.java	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/com/google/caja/reporting/RenderContext.java	View	1 2	3 chunks	+24 lines, -8 lines	5 comments	Download
M	tests/com/google/caja/plugin/BrowserTestCase.java	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Jasvir

LGTM http://codereview.appspot.com/4610043/diff/7/src/com/google/caja/reporting/RenderContext.java File src/com/google/caja/reporting/RenderContext.java (right): http://codereview.appspot.com/4610043/diff/7/src/com/google/caja/reporting/RenderContext.java#newcode86 src/com/google/caja/reporting/RenderContext.java:86: // Enforce that derive has been overridden. Clever.

15 years, 4 months ago (2011-06-14 21:11:14 UTC) #2

MikeSamuel

http://codereview.appspot.com/4610043/diff/7/src/com/google/caja/reporting/RenderContext.java File src/com/google/caja/reporting/RenderContext.java (right): http://codereview.appspot.com/4610043/diff/7/src/com/google/caja/reporting/RenderContext.java#newcode86 src/com/google/caja/reporting/RenderContext.java:86: // Enforce that derive has been overridden. On 2011/06/14 ...

15 years, 4 months ago (2011-06-14 22:13:12 UTC) #3

felix8a

15 years, 4 months ago (2011-06-14 22:44:33 UTC) #4

MikeSamuel

15 years, 4 months ago (2011-06-14 22:47:34 UTC) #5

felix8a

15 years, 4 months ago (2011-06-14 22:50:54 UTC) #6

http://codereview.appspot.com/4610043/diff/7/src/com/google/caja/reporting/Re...
File src/com/google/caja/reporting/RenderContext.java (right):

http://codereview.appspot.com/4610043/diff/7/src/com/google/caja/reporting/Re...
src/com/google/caja/reporting/RenderContext.java:86: // Enforce that derive has
been overridden.
On 2011/06/14 22:47:34, MikeSamuel wrote:
> yep.  Not when we run our tests though, so we will detect any tested classes
> that do this.  I could always change this to throw new AssertionError if you
> think it is worthwhile to have this always on.

catching in testing is probably enough.

Expand All Messages | Collapse All Messages