Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 4609042: code review 4609042: doc/effective_go.html: replace tab with spaces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by r
Modified:
13 years, 11 months ago
Reviewers:
adg
CC:
golang-dev, gri
Visibility:
Public.

Description

doc/effective_go.html: replace tab with spaces.

Patch Set 1 #

Patch Set 2 : diff -r 93d34d943e25 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M doc/effective_go.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 11 months ago (2011-06-13 04:15:25 UTC) #1
gri
LGTM On Sun, Jun 12, 2011 at 9:15 PM, <r@golang.org> wrote: > Reviewers: golang-dev_googlegroups.com, > ...
13 years, 11 months ago (2011-06-13 04:55:13 UTC) #2
r
*** Submitted as http://code.google.com/p/go/source/detail?r=d086bab9b037 *** doc/effective_go.html: replace tab with spaces. R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/4609042
13 years, 11 months ago (2011-06-15 14:13:24 UTC) #3
adg
Why?
13 years, 11 months ago (2011-06-15 23:02:15 UTC) #4
gri
13 years, 11 months ago (2011-06-15 23:27:10 UTC) #5
all the other code in that file is aligned with spaces - using spaces
may yield a more predictable look on web pages (for instance, we do it
in godoc, albeit not for source code anymore, just for documentation)
- gri

On Wed, Jun 15, 2011 at 4:01 PM, Andrew Gerrand <adg@golang.org> wrote:
> Why?
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b