Issue 46080043: 'transparent' is now a CSS color

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 46080043: 'transparent' is now a CSS color (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by felix8a

Modified:
12 years, 2 months ago

Reviewers:
kpreid2

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

'transparent' used to be a special keyword in some CSS rules. CSS3 makes 'transparent' a color keyword, and it's valid anywhere a color is valid. This change makes 'transparent' a color.

Patch Set 1 #

Patch Set 2 : 'transparent' is now a CSS color #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -9 lines)			Patch
M	.	View	1	0 chunks	+0 lines, -0 lines	0 comments	Download
M	src/com/google/caja/lang/css/css3-defs.json	View	1	5 chunks	+9 lines, -6 lines	0 comments	Download
M	tests/com/google/caja/lang/css/CssPropertyPatternsTest.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/CssValidatorTest.java	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

felix8a

'transparent' used to be a special keyword in some CSS rules. CSS3 makes 'transparent' a ...

12 years, 2 months ago (2013-12-28 00:17:37 UTC) #3

felix8a

updated snapshot for es53 branch. changing the css grammar affects some tests that expect particular ...

12 years, 2 months ago (2013-12-28 00:18:35 UTC) #4

@r5651 trunk
@r5653 branches/es53

Expand All Messages | Collapse All Messages