src/pkg/http/fs.go - Issue 4607052: code review 4607052: os.Error API: don't export os.ErrorString, use os.NewEr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/http/fs.go

Issue 4607052: code review 4607052: os.Error API: don't export os.ErrorString, use os.NewEr... (Closed)

Patch Set: diff -r 6e3e06fb2dc3 https://go.googlecode.com/hg/ Created 13 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/http/fs.go

===================================================================

--- a/src/pkg/http/fs.go

+++ b/src/pkg/http/fs.go

@@ -157,7 +157,7 @@

// TODO(adg): handle multiple ranges

ranges, err := parseRange(r.Header.Get("Range"), size)

if err == nil && len(ranges) > 1 {

- err = os.ErrorString("multiple ranges not supported")

+ err = os.NewError("multiple ranges not supported")

}

if err != nil {

Error(w, err.String(), StatusRequestedRangeNotSatisfiable)

« no previous file with comments | « src/pkg/http/client.go ('k') | src/pkg/http/request.go » ('j') | no next file with comments »