src/pkg/compress/gzip/gunzip.go - Issue 4607052: code review 4607052: os.Error API: don't export os.ErrorString, use os.NewEr...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/compress/gzip/gunzip.go

Issue 4607052: code review 4607052: os.Error API: don't export os.ErrorString, use os.NewEr... (Closed)

Patch Set: diff -r 6e3e06fb2dc3 https://go.googlecode.com/hg/ Created 13 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/compress/gzip/gunzip.go

===================================================================

--- a/src/pkg/compress/gzip/gunzip.go

+++ b/src/pkg/compress/gzip/gunzip.go

@@ -36,8 +36,8 @@

return bufio.NewReader(r)

}

-var HeaderError os.Error = os.ErrorString("invalid gzip header")

-var ChecksumError os.Error = os.ErrorString("gzip checksum error")

+var HeaderError = os.NewError("invalid gzip header")

+var ChecksumError = os.NewError("gzip checksum error")

// The gzip file stores a header giving metadata about the compressed file.

// That header is exposed as the fields of the Compressor and Decompressor structs.

« no previous file with comments | « src/pkg/bytes/buffer.go ('k') | src/pkg/compress/zlib/reader.go » ('j') | no next file with comments »