code review 4607052: os.Error API: don't export os.ErrorString, use os.NewEr...

src/pkg/xml/read.go

 // Copyright 2009 The Go Authors.  All rights reserved.
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
 package xml
 
 import (
         "bytes"
         "fmt"
         "io"
@@ skipping 233 matching lines @@
                 saveXML      reflect.Value
                 saveXMLIndex int
                 saveXMLData  []byte
                 sv           reflect.Value
                 styp         reflect.Type
                 fieldPaths   map[string]pathInfo
         )
 
         switch v := val; v.Kind() {
         default:
-                return os.ErrorString("unknown type " + v.Type().String())
+                return os.NewError("unknown type " + v.Type().String())
 
         case reflect.Slice:
                 typ := v.Type()
                 if typ.Elem().Kind() == reflect.Uint8 {
                         // []byte
                         saveData = v
                         break
                 }
 
                 // Slice of element values.
@@ skipping 236 matching lines @@
                 ftmp, err = strconv.Atof64(string(src))
                 // TODO: check for overflow?
                 return err == nil
         }
 
         // Save accumulated data and comments
         switch t := dst; t.Kind() {
         case reflect.Invalid:
                 // Probably a comment, handled below
         default:
-                return os.ErrorString("cannot happen: unknown type " + t.Type().String())
+                return os.NewError("cannot happen: unknown type " + t.Type().String())
         case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
                 if !getInt64() {
                         return err
                 }
                 t.SetInt(itmp)
         case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
                 if !getUint64() {
                         return err
                 }
                 t.SetUint(utmp)
@@ skipping 99 matching lines @@
                 case StartElement:
                         if err := p.Skip(); err != nil {
                                 return err
                         }
                 case EndElement:
                         return nil
                 }
         }
         panic("unreachable")
 }