Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4164)

Issue 4607045: code review 4607045: cgo: handle new Apple LLVM-based gcc from Xcode 4.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by rsc
Modified:
8 years, 5 months ago
Reviewers:
CC:
iant, golang-dev
Visibility:
Public.

Description

cgo: handle new Apple LLVM-based gcc from Xcode 4.2 That gcc does not include enumerator names and values in its DWARF debug output. Create a data block from which we can read the values instead. Fixes issue 1881.

Patch Set 1 #

Patch Set 2 : diff -r 5e5d55182675 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 5e5d55182675 https://go.googlecode.com/hg #

Total comments: 1

Patch Set 4 : diff -r 83bf1e008e3e https://go.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -19 lines) Patch
M src/cmd/cgo/gcc.go View 1 2 5 chunks +72 lines, -17 lines 0 comments Download
M src/pkg/debug/dwarf/type.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/debug/elf/file.go View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
8 years, 5 months ago (2011-06-13 17:21:48 UTC) #1
iant
LGTM http://codereview.appspot.com/4607045/diff/3/src/pkg/debug/elf/file.go File src/pkg/debug/elf/file.go (right): http://codereview.appspot.com/4607045/diff/3/src/pkg/debug/elf/file.go#newcode550 src/pkg/debug/elf/file.go:550: func (f *File) Symbols() ([]Symbol, os.Error) { This ...
8 years, 5 months ago (2011-06-13 18:29:03 UTC) #2
rsc
> This seems unrelated. I needed it until I decided not to bother extracting __cgodebug_data ...
8 years, 5 months ago (2011-06-13 18:43:26 UTC) #3
rsc
8 years, 5 months ago (2011-06-13 18:43:58 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=142f0bc0d6e7 ***

cgo: handle new Apple LLVM-based gcc from Xcode 4.2

That gcc does not include enumerator names and values
in its DWARF debug output.  Create a data block from which
we can read the values instead.

Fixes issue 1881.

R=iant
CC=golang-dev
http://codereview.appspot.com/4607045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b