code review 4602050: gopack: remove warning from the use of mktemp

gopack: remove warning from the use of mktemp

gcc-4.6 considers mktemp to be racey

[dave_cheney.net, 2011-06-10 00:53:01]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[dave_cheney.net, 2011-06-10 00:53:30]

Tested on darwin and linux. If someone from the plan 9 fold can test that would
be super.

[rsc, 2011-06-10 00:58:51]

This code is never called.
You can replace the whole function with

sysfatal("page");

[iant2, 2011-06-10 01:04:23]

LGTM

dave@cheney.net writes:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> gopack: remove warning from the use of mktemp
>
> gcc-4.6 considers mktemp to be racey
>
> Please review this at http://codereview.appspot.com/4602050/
>
> Affected files:
>   M src/cmd/gopack/ar.c
>
>
> Index: src/cmd/gopack/ar.c
> ===================================================================
> --- a/src/cmd/gopack/ar.c
> +++ b/src/cmd/gopack/ar.c
> @@ -1536,8 +1536,7 @@
>
>  	bp = ap->head;
>  	if (!ap->paged) {		/* not yet paged - create file */
> -		ap->fname = mktemp(ap->fname);
> -		ap->fd = create(ap->fname, ORDWR|ORCLOSE, 0600);
> +		ap->fd = mkstemp(ap->fname);
>  		if (ap->fd < 0) {
>  			fprint(2,"gopack: can't create temp file\n");
>  			return 0;

[iant, 2011-06-10 01:04:38]

*** Submitted as http://code.google.com/p/go/source/detail?r=b2d04a287628 ***

gopack: remove warning from the use of mktemp

gcc-4.6 considers mktemp to be racey

R=golang-dev, rsc, iant
CC=golang-dev
http://codereview.appspot.com/4602050

Committer: Ian Lance Taylor <iant@golang.org>

[iant2, 2011-06-10 01:06:11]

Russ Cox <rsc@golang.org> writes:

> This code is never called.
> You can replace the whole function with
>
> sysfatal("page");

Whoops, sorry, just saw this after I submitted it.

Ian

[dave_cheney.net, 2011-06-10 01:08:19]

Thanks Ian.

Russ, this following on CL reduces the function to a call to sysfatal,

http://codereview.appspot.com/4601051

Cheers

Dave


On Fri, Jun 10, 2011 at 11:04 AM,  <iant@golang.org> wrote:
> *** Submitted as
> http://code.google.com/p/go/source/detail?r=b2d04a287628 ***
>
> gopack: remove warning from the use of mktemp
>
> gcc-4.6 considers mktemp to be racey
>
> R=golang-dev, rsc, iant
> CC=golang-dev
> http://codereview.appspot.com/4602050
>
> Committer: Ian Lance Taylor <iant@golang.org>
>
>
> http://codereview.appspot.com/4602050/
>

[rsc, 2011-06-10 01:08:52]

No worries.  Please do replace the function though,
since there is no mkstemp on Plan 9.

[dave_cheney.net, 2011-06-10 01:15:02]

If you happy to have armalloc exit if malloc fails, then I can remove
page's calling function.

Please let me know if that is ok, and I'll update 4601051

On Fri, Jun 10, 2011 at 11:08 AM, Russ Cox <rsc@golang.org> wrote:
> No worries.  Please do replace the function though,
> since there is no mkstemp on Plan 9.
>