windows: define and use syscall.Handle

windows: define and use syscall.Handle
Fixes issue 1487.

[vcc, 2011-06-13 15:29:50]

I'd like you to review this change.

[peterGo, 2011-06-13 20:23:55]

linux/amd64, hg id 53460e066c2f+ tip.

INSTALL FAIL os
make[1]: Entering directory `/home/peter/handle/src/pkg/os'
./mkunixsignals.sh ../syscall/zerrors_linux_amd64.go > signal_unix.go || rm -f
signal_unix.go
6g  -o _go_.6 error.go env.go exec.go file.go getwd.go path.go proc.go
stat_linux.go time.go types.go  dir_unix.go error_posix.go env_unix.go
file_posix.go file_unix.go path_unix.go sys_linux.go exec_posix.go exec_unix.go
signal_unix.go 
exec.go:39: undefined: File
file.go:28: undefined: File
file.go:86: undefined: File
file.go:107: undefined: File
file.go:130: undefined: File
file.go:150: undefined: File
file.go:171: undefined: File
file.go:184: undefined: File
file.go:213: undefined: File
file.go:224: undefined: File
file.go:224: too many errors
make[1]: *** [_go_.6] Error 1
make[1]: Leaving directory `/home/peter/handle/src/pkg/os'
make: *** [os.install] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/peter/handle/src/pkg'

Peter

[peterGo, 2011-06-13 20:39:49]

windows/386, hg id 53460e066c2f+ tip.

--- cd ../doc/progs
file.go:25: cannot use syscall.Stdin (type syscall.Handle) as type int in
function argument
file.go:26: cannot use syscall.Stdout (type syscall.Handle) as type int in
function argument
file.go:27: cannot use syscall.Stderr (type syscall.Handle) as type int in
function argument
file.go:35: cannot use r (type syscall.Handle) as type int in function argument
file.go:57: cannot use file.fd (type int) as type syscall.Handle in function
argument
file.go:69: cannot use file.fd (type int) as type syscall.Handle in function
argument
file.go:80: cannot use file.fd (type int) as type syscall.Handle in function
argument

Peter

[peterGo, 2011-06-13 20:48:35]

"The special sentence 'Fixes issue 159.' associates the change with issue 159 in
the Go issue tracker. When this change is eventually submitted, the issue
tracker will automatically mark the issue as fixed."
Contribution Guidelines: http://golang.org/doc/contribute.html.

Is the "Fixed issue 1487." sentence in the CL description close enough to “Fixes
issue 1487.” for the issue to be marked as fixed?

Peter

[rsc, 2011-06-13 20:57:52]

no please s/Fixed/Fixes/

[mikio, 2011-06-14 00:09:00]

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/Makefile
File src/pkg/net/Makefile (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/Makefile#oldcode31
src/pkg/net/Makefile:31: interface_bsd.go\
I'd prefer interface_..go then ipsock_...go, ordered by filename.

[mattn, 2011-06-14 00:43:39]

I didn't review all.

* socket is not a handle.
* fd is not a handle.

handle is void*

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows.go
File src/pkg/syscall/syscall_windows.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows....
src/pkg/syscall/syscall_windows.go:471: //sys	socket(af int32, typ int32,
protocol int32) (handle int32, errno int) [failretval==-1] = wsock32.socket
socket is not a handle.
please revert to original. or define type socket.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows.go
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows....
src/pkg/syscall/syscall_windows.go:708: func Fchdir(fd Handle) (errno int)      
                    { return EWINDOWS }
same about socket.
fd is not a handle.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
File src/pkg/syscall/zsyscall_windows_386.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1046: func socket(af int32, typ int32,
protocol int32) (handle Handle, errno int) {
socket is not a handle.
variable name is wrong.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1061: func setsockopt(s Handle, level
int32, optname int32, optval *byte, optlen int32) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1075: func bind(s Handle, name uintptr,
namelen int32) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1089: func connect(s Handle, name
uintptr, namelen int32) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1103: func getsockname(s Handle, rsa
*RawSockaddrAny, addrlen *int32) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1117: func getpeername(s Handle, rsa
*RawSockaddrAny, addrlen *int32) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1131: func listen(s Handle, backlog
int32) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1145: func shutdown(s Handle, how int32)
(errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1159: func Closesocket(s Handle) (errno
int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1173: func AcceptEx(ls Handle, as
Handle, buf *byte, rxdatalen uint32, laddrlen uint32, raddrlen uint32, recvd
*uint32, overlapped *Overlapped) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1192: func WSARecv(s Handle, bufs
*WSABuf, bufcnt uint32, recvd *uint32, flags *uint32, overlapped *Overlapped,
croutine *byte) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1206: func WSASend(s Handle, bufs
*WSABuf, bufcnt uint32, sent *uint32, flags uint32, overlapped *Overlapped,
croutine *byte) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1220: func WSARecvFrom(s Handle, bufs
*WSABuf, bufcnt uint32, recvd *uint32, flags *uint32, from *RawSockaddrAny,
fromlen *int32, overlapped *Overlapped, croutine *byte) (errno int) {
same above.

http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
src/pkg/syscall/zsyscall_windows_386.go:1234: func WSASendTo(s Handle, bufs
*WSABuf, bufcnt uint32, sent *uint32, flags uint32, to *RawSockaddrAny, tolen
int32, overlapped *Overlapped, croutine *byte) (errno int) {
same above.

[brainman, 2011-06-14 01:53:02]

Wei,

Your change will break build:

--- cd ../doc/progs
file.go:25: cannot use syscall.Stdin (type syscall.Handle) as type int in
function argument
file.go:26: cannot use syscall.Stdout (type syscall.Handle) as type int in
function argument
file.go:27: cannot use syscall.Stderr (type syscall.Handle) as type int in
function argument
file.go:35: cannot use r (type syscall.Handle) as type int in function argument
file.go:57: cannot use file.fd (type int) as type syscall.Handle in function
argument
file.go:69: cannot use file.fd (type int) as type syscall.Handle in function
argument
file.go:80: cannot use file.fd (type int) as type syscall.Handle in function
argument

You did what issue 1487 asking you to do "os.File's Fd method should return
syscall.Handle on Windows", but I am not sure now, it is the right way forward.
It would be nice if things outside of syscall package could remain the same and
use int everywhere. Other OSes do - I need to be convinced, it can't be done
with windows.

It is hard for me to make judgements without seeing 64 bit windows
implementation that builds, even if up to some point. I would rather leave this
change until we see a such thing.

Alex

[vcc, 2011-06-14 03:18:08]

2011/6/14  <mattn.jp@gmail.com>:
> I didn't review all.
>
> * socket is not a handle.
> * fd is not a handle.

socket and file handle is 64bit on win64, is a handle.

> handle is void*
>
>
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows.go
> File src/pkg/syscall/syscall_windows.go (left):
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows....
> src/pkg/syscall/syscall_windows.go:471: //sys   socket(af int32, typ
> int32, protocol int32) (handle int32, errno int) [failretval==-1] =
> wsock32.socket
> socket is not a handle.
> please revert to original. or define type socket.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows.go
> File src/pkg/syscall/syscall_windows.go (right):
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/syscall_windows....
> src/pkg/syscall/syscall_windows.go:708: func Fchdir(fd Handle) (errno
> int)                           { return EWINDOWS }
> same about socket.
> fd is not a handle.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> File src/pkg/syscall/zsyscall_windows_386.go (right):
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1046: func socket(af int32, typ
> int32, protocol int32) (handle Handle, errno int) {
> socket is not a handle.
> variable name is wrong.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1061: func setsockopt(s Handle,
> level int32, optname int32, optval *byte, optlen int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1075: func bind(s Handle, name
> uintptr, namelen int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1089: func connect(s Handle,
> name uintptr, namelen int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1103: func getsockname(s Handle,
> rsa *RawSockaddrAny, addrlen *int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1117: func getpeername(s Handle,
> rsa *RawSockaddrAny, addrlen *int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1131: func listen(s Handle,
> backlog int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1145: func shutdown(s Handle,
> how int32) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1159: func Closesocket(s Handle)
> (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1173: func AcceptEx(ls Handle,
> as Handle, buf *byte, rxdatalen uint32, laddrlen uint32, raddrlen
> uint32, recvd *uint32, overlapped *Overlapped) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1192: func WSARecv(s Handle,
> bufs *WSABuf, bufcnt uint32, recvd *uint32, flags *uint32, overlapped
> *Overlapped, croutine *byte) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1206: func WSASend(s Handle,
> bufs *WSABuf, bufcnt uint32, sent *uint32, flags uint32, overlapped
> *Overlapped, croutine *byte) (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1220: func WSARecvFrom(s Handle,
> bufs *WSABuf, bufcnt uint32, recvd *uint32, flags *uint32, from
> *RawSockaddrAny, fromlen *int32, overlapped *Overlapped, croutine *byte)
> (errno int) {
> same above.
>
>
http://codereview.appspot.com/4600042/diff/1/src/pkg/syscall/zsyscall_windows...
> src/pkg/syscall/zsyscall_windows_386.go:1234: func WSASendTo(s Handle,
> bufs *WSABuf, bufcnt uint32, sent *uint32, flags uint32, to
> *RawSockaddrAny, tolen int32, overlapped *Overlapped, croutine *byte)
> (errno int) {
> same above.
>
> http://codereview.appspot.com/4600042/
>

[vcc, 2011-06-14 03:27:39]

On 2011/06/13 20:57:52, rsc wrote:
> no please s/Fixed/Fixes/

Done.

[mattn, 2011-06-14 03:37:01]

Hmm, I found spec.

http://msdn.microsoft.com/en-us/library/ms740522(VS.85).aspx

LGTM about reason of changes. :)

[rsc, 2011-06-14 17:11:07]

This looks very good.  Just a few small things below that can simplify the
changes.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock.go
File src/pkg/net/ipsock.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock.go#oldcode14
src/pkg/net/ipsock.go:14: // Should we try to use the IPv4 socket interface if
we're
I don't think this code needs to be deleted.  See next comment.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock.go#oldcode29
src/pkg/net/ipsock.go:29: s  int
It looks like this is the reason for the deletion, but this doesn't need to be
in the struct.  I'd delete this one line and then adjust the code below to use
:=.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_unix.go
File src/pkg/net/ipsock_unix.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_unix.go#newcode1
src/pkg/net/ipsock_unix.go:1: // Copyright 2011 The Go Authors.  All rights
reserved.
This file is then unnecessary.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_windows.go
File src/pkg/net/ipsock_windows.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_windows.go#ne...
src/pkg/net/ipsock_windows.go:1: // Copyright 2011 The Go Authors.  All rights
reserved.
This file is then unnecessary.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock.go
File src/pkg/net/sock.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock.go#oldcode24
src/pkg/net/sock.go:24: // Generic socket creation.
I don't see why this moved either.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock.go#oldcode68
src/pkg/net/sock.go:68: func setsockoptInt(fd, level, opt int, value int)
os.Error {
I see why this moved, but a better solution here is to make the
first parameter have type *netFD.  Same for setsockoptNsec.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock_unix.go
File src/pkg/net/sock_unix.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock_unix.go#newcode1
src/pkg/net/sock_unix.go:1: // Copyright 2011 The Go Authors.  All rights
reserved.
This file should be unnecessary.

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/exec_posix.go
File src/pkg/os/exec_posix.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/exec_posix.go#oldcode37
src/pkg/os/exec_posix.go:37: // Create array of integer (system) fds.
I don't think this needs to move anymore.  Just rewrite the code to say

for i, f := range attr.Files {
    sysattr.Files = append(sysattr.Files, f.Fd())
}

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/file.go
File src/pkg/os/file.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/file.go#newcode15
src/pkg/os/file.go:15: // File represents an open file descriptor.
copy into file_posix or file_unix

[vcc, 2011-06-15 05:50:27]

PTAL

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock.go
File src/pkg/net/ipsock.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock.go#oldcode14
src/pkg/net/ipsock.go:14: // Should we try to use the IPv4 socket interface if
we're
On 2011/06/14 17:11:07, rsc wrote:
> I don't think this code needs to be deleted.  See next comment.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock.go#oldcode29
src/pkg/net/ipsock.go:29: s  int
On 2011/06/14 17:11:07, rsc wrote:
> It looks like this is the reason for the deletion, but this doesn't need to be
> in the struct.  I'd delete this one line and then adjust the code below to use
> :=.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_unix.go
File src/pkg/net/ipsock_unix.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_unix.go#newcode1
src/pkg/net/ipsock_unix.go:1: // Copyright 2011 The Go Authors.  All rights
reserved.
On 2011/06/14 17:11:07, rsc wrote:
> This file is then unnecessary.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_windows.go
File src/pkg/net/ipsock_windows.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/ipsock_windows.go#ne...
src/pkg/net/ipsock_windows.go:1: // Copyright 2011 The Go Authors.  All rights
reserved.
On 2011/06/14 17:11:07, rsc wrote:
> This file is then unnecessary.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock.go
File src/pkg/net/sock.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock.go#oldcode24
src/pkg/net/sock.go:24: // Generic socket creation.
On 2011/06/14 17:11:07, rsc wrote:
> I don't see why this moved either.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock.go#oldcode68
src/pkg/net/sock.go:68: func setsockoptInt(fd, level, opt int, value int)
os.Error {
On 2011/06/14 17:11:07, rsc wrote:
> I see why this moved, but a better solution here is to make the
> first parameter have type *netFD.  Same for setsockoptNsec.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock_unix.go
File src/pkg/net/sock_unix.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/net/sock_unix.go#newcode1
src/pkg/net/sock_unix.go:1: // Copyright 2011 The Go Authors.  All rights
reserved.
On 2011/06/14 17:11:07, rsc wrote:
> This file should be unnecessary.

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/exec_posix.go
File src/pkg/os/exec_posix.go (left):

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/exec_posix.go#oldcode37
src/pkg/os/exec_posix.go:37: // Create array of integer (system) fds.
On 2011/06/14 17:11:07, rsc wrote:
> I don't think this needs to move anymore.  Just rewrite the code to say
> 
> for i, f := range attr.Files {
>     sysattr.Files = append(sysattr.Files, f.Fd())
> }
> 

Done.

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/file.go
File src/pkg/os/file.go (right):

http://codereview.appspot.com/4600042/diff/1/src/pkg/os/file.go#newcode15
src/pkg/os/file.go:15: // File represents an open file descriptor.
On 2011/06/14 17:11:07, rsc wrote:
> copy into file_posix or file_unix

Done.

[peterGo, 2011-06-15 13:27:14]

vcc,

On 2011/06/15 05:50:27, vcc wrote:
> PTAL

linux/arm64, hg id e23f10e3fe00+ tip.

./all.bash

INSTALL FAIL os
make[1]: Entering directory `/home/peter/handle/src/pkg/os'
./mkunixsignals.sh ../syscall/zerrors_linux_amd64.go > signal_unix.go || rm -f
signal_unix.go
6g  -o _go_.6 error.go env.go exec.go file.go getwd.go path.go proc.go
stat_linux.go time.go types.go  dir_unix.go error_posix.go env_unix.go
file_posix.go file_unix.go path_unix.go sys_linux.go exec_posix.go exec_unix.go
signal_unix.go 
exec_posix.go:40: cannot use 18446744073709551615 (type syscall.Handle) as type
int in append
make[1]: *** [_go_.6] Error 1
make[1]: Leaving directory `/home/peter/handle/src/pkg/os'
make: *** [os.install] Error 1
make: *** Waiting for unfinished jobs....
make: Leaving directory `/home/peter/handle/src/pkg'

Peter

[peterGo, 2011-06-15 14:22:58]

vcc,

On 2011/06/15 05:50:27, vcc wrote:
> PTAL

This looks like the same set of errors that I reported yesterday.

windows/386, hg id 6bf5e0a7d60a+.

./all.bash

--- cd ../doc/progs

file.go:25: cannot use syscall.Stdin (type syscall.Handle) as type int in
function argument

file.go:26: cannot use syscall.Stdout (type syscall.Handle) as type int in
function argument

file.go:27: cannot use syscall.Stderr (type syscall.Handle) as type int in
function argument

file.go:35: cannot use r (type syscall.Handle) as type int in function argument

file.go:57: cannot use file.fd (type int) as type syscall.Handle in function
argument

file.go:69: cannot use file.fd (type int) as type syscall.Handle in function
argument

file.go:80: cannot use file.fd (type int) as type syscall.Handle in function
argument

Peter

[vcc, 2011-06-16 05:29:26]

PTAL

Shouldn't break build now.

[peterGo, 2011-06-16 21:39:27]

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:18: small demo to detect version of windows
you are running:
This program is commented out. However, it should compile and run. It doesn't;
it complains that you missed something. See line 43.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:43: proc, err := syscall.GetProcAddress(h,
"GetVersion")
8g error: cannot use h (type syscall.Handle) as type uint32 in function argument

[peterGo, 2011-06-16 23:11:35]

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:80: func loadlibraryex(filename uintptr)
(handle uint32)
s/handle uint32/handle uintptr/
HMODULE A handle to a module. <== typedef HINSTANCE HMODULE; <== typedef HANDLE
HINSTANCE;
Windows Data Types
http://msdn.microsoft.com/en-us/library/aa383751.aspx

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:81: func getprocaddress(handle uint32,
procname uintptr) (proc uintptr)
s/handle uint32/handle uintptr/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:83: func loadDll(fname string) uint32 {
s/uint32/uintptr/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:91: func getSysProcAddr(m uint32, pname
string) uintptr {
s/m uint32/m uintptr/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:110: type Handle uintptr
Move this up to before first use.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:112: const InvalidHandle = ^Handle(0)
Move this up along with type Handle.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:133: //sys	GetCurrentDirectory(buflen Handle,
buf *uint16) (n uint32, errno int) = GetCurrentDirectoryW
s/buflen Handle/buflen uint32/
DWORD

[peterGo, 2011-06-17 03:21:24]

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:80: func loadlibraryex(filename uintptr)
(handle uint32)
correction
s/handle uint32/handle Handle/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:81: func getprocaddress(handle uint32,
procname uintptr) (proc uintptr)
correction
s/handle uint32/handle Handle/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:83: func loadDll(fname string) uint32 {
correction
s/uint32/Handle/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:91: func getSysProcAddr(m uint32, pname
string) uintptr {
correction
s/m uint32/m Handle/
HMODULE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:153:
//sys	DuplicateHandle(hSourceProcessHandle Handle, hSourceHandle Handle,
hTargetProcessHandle Handle, lpTargetHandle *int32, dwDesiredAccess uint32,
bInheritHandle bool, dwOptions uint32) (errno int)
s/lpTargetHandle *int32/lpTargetHandle *Handle/
LPHANDLE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:158: //sys	CryptAcquireContext(provhandle
*uint32, container *uint16, provider *uint16, provtype uint32, flags uint32)
(errno int) = advapi32.CryptAcquireContextW
s/provhandle *uint32/provhandle *Handle/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:159: //sys	CryptReleaseContext(provhandle
uint32, flags uint32) (errno int) = advapi32.CryptReleaseContext
s/provhandle uint32/provhandle Handle/
HCRYPTPROV

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:160: //sys	CryptGenRandom(provhandle uint32,
buflen uint32, buf *byte) (errno int) = advapi32.CryptGenRandom
s/provhandle uint32/provhandle Handle/
HCRYPTPROV

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:165: //sys	SetFileTime(handle int32, ctime
*Filetime, atime *Filetime, wtime *Filetime) (errno int)
s/handle int32/handle Handle/
HANDLE

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:170: //sys	LocalFree(hmem uint32) (handle
Handle, errno int) [failretval!=0]
s/hmem uint32/hmem Handle/
HLOCAL

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:180: //sys	TransmitFile(s int32, handle
int32, bytesToWrite uint32, bytsPerSend uint32, overlapped *Overlapped,
transmitFileBuf *TransmitFileBuffers, flags uint32) (errno int) =
wsock32.TransmitFile
s/handle int32/handle Handle/
HANDLE

[peterGo, 2011-06-17 03:53:31]

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:251: return Handle(h), int(e)
s/Handle(h)/h/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:256: e := ReadFile(Handle(fd), p, &done, nil)
s/Handle(fd)/fd/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:269: e := WriteFile(Handle(fd), p, &done,
nil)
s/Handle(fd)/fd/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:289: ft, _ := GetFileType(Handle(fd))
s/Handle(fd)/fd/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:293: rlo, e := SetFilePointer(Handle(fd), lo,
&hi, w)
s/Handle(fd)/fd/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:301: return CloseHandle(Handle(fd))
s/Handle(fd)/fd/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:312: return Handle(r)
s/Handle(r)/r/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:401: e = SetEndOfFile(Handle(fd))
s/Handle(fd)/fd/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:444: defer Close(Handle(h))
s/Handle(h)/h/

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:451: return FlushFileBuffers(Handle(fd))
s/Handle(fd)/fd/

[vcc, 2011-06-17 05:01:04]

PTAL

Thanks for review.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
File src/pkg/syscall/syscall_windows.go (right):

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:18: small demo to detect version of windows
you are running:
On 2011/06/16 21:39:28, peterGo wrote:
> This program is commented out. However, it should compile and run. It doesn't;
> it complains that you missed something. See line 43.

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:80: func loadlibraryex(filename uintptr)
(handle uint32)
On 2011/06/16 23:11:36, peterGo wrote:
> s/handle uint32/handle uintptr/
> HMODULE A handle to a module. <== typedef HINSTANCE HMODULE; <== typedef
HANDLE
> HINSTANCE;
> Windows Data Types
> http://msdn.microsoft.com/en-us/library/aa383751.aspx

Done with uintptr, uintptr is ok, define in ../runtime/windows/syscall.goc is
uintptr.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:81: func getprocaddress(handle uint32,
procname uintptr) (proc uintptr)
On 2011/06/16 23:11:36, peterGo wrote:
> s/handle uint32/handle uintptr/
> HMODULE

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:83: func loadDll(fname string) uint32 {
On 2011/06/16 23:11:36, peterGo wrote:
> s/uint32/uintptr/
> HMODULE

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:91: func getSysProcAddr(m uint32, pname
string) uintptr {
On 2011/06/16 23:11:36, peterGo wrote:
> s/m uint32/m uintptr/
> HMODULE

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:110: type Handle uintptr
On 2011/06/16 23:11:36, peterGo wrote:
> Move this up to before first use.

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:112: const InvalidHandle = ^Handle(0)
On 2011/06/16 23:11:36, peterGo wrote:
> Move this up along with type Handle.

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:133: //sys	GetCurrentDirectory(buflen Handle,
buf *uint16) (n uint32, errno int) = GetCurrentDirectoryW
On 2011/06/16 23:11:36, peterGo wrote:
> s/buflen Handle/buflen uint32/
> DWORD
> 

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:153:
//sys	DuplicateHandle(hSourceProcessHandle Handle, hSourceHandle Handle,
hTargetProcessHandle Handle, lpTargetHandle *int32, dwDesiredAccess uint32,
bInheritHandle bool, dwOptions uint32) (errno int)
On 2011/06/17 03:21:24, peterGo wrote:
> s/lpTargetHandle *int32/lpTargetHandle *Handle/
> LPHANDLE

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:158: //sys	CryptAcquireContext(provhandle
*uint32, container *uint16, provider *uint16, provtype uint32, flags uint32)
(errno int) = advapi32.CryptAcquireContextW
On 2011/06/17 03:21:24, peterGo wrote:
> s/provhandle *uint32/provhandle *Handle/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:159: //sys	CryptReleaseContext(provhandle
uint32, flags uint32) (errno int) = advapi32.CryptReleaseContext
On 2011/06/17 03:21:24, peterGo wrote:
> s/provhandle uint32/provhandle Handle/
> HCRYPTPROV

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:160: //sys	CryptGenRandom(provhandle uint32,
buflen uint32, buf *byte) (errno int) = advapi32.CryptGenRandom
On 2011/06/17 03:21:24, peterGo wrote:
> s/provhandle uint32/provhandle Handle/
> HCRYPTPROV

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:165: //sys	SetFileTime(handle int32, ctime
*Filetime, atime *Filetime, wtime *Filetime) (errno int)
On 2011/06/17 03:21:24, peterGo wrote:
> s/handle int32/handle Handle/
> HANDLE

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:170: //sys	LocalFree(hmem uint32) (handle
Handle, errno int) [failretval!=0]
On 2011/06/17 03:21:24, peterGo wrote:
> s/hmem uint32/hmem Handle/
> HLOCAL

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:180: //sys	TransmitFile(s int32, handle
int32, bytesToWrite uint32, bytsPerSend uint32, overlapped *Overlapped,
transmitFileBuf *TransmitFileBuffers, flags uint32) (errno int) =
wsock32.TransmitFile
On 2011/06/17 03:21:24, peterGo wrote:
> s/handle int32/handle Handle/
> HANDLE

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:251: return Handle(h), int(e)
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(h)/h/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:256: e := ReadFile(Handle(fd), p, &done, nil)
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:269: e := WriteFile(Handle(fd), p, &done,
nil)
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:289: ft, _ := GetFileType(Handle(fd))
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:293: rlo, e := SetFilePointer(Handle(fd), lo,
&hi, w)
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:301: return CloseHandle(Handle(fd))
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:312: return Handle(r)
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(r)/r/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:401: e = SetEndOfFile(Handle(fd))
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:444: defer Close(Handle(h))
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(h)/h/

Done.

http://codereview.appspot.com/4600042/diff/23001/src/pkg/syscall/syscall_wind...
src/pkg/syscall/syscall_windows.go:451: return FlushFileBuffers(Handle(fd))
On 2011/06/17 03:53:31, peterGo wrote:
> s/Handle(fd)/fd/

Done.

[peterGo, 2011-06-17 08:09:37]

vcc,

windows/386, hg id 12118c2a9829+ tip.

./all.bash

install os
INSTALL FAIL os
make[1]: Entering directory `/c/handle/src/pkg/os'
./mkunixsignals.sh ../syscall/ztypes_windows_386.go > signal_windows.go || rm -f
 signal_windows.go
8g  -o _go_.8 error.go env.go exec.go file.go getwd.go path.go proc.go stat_wind
ows.go time.go types.go  dir_windows.go error_posix.go env_windows.go file_posix
.go file_windows.go path_windows.go sys_windows.go exec_posix.go exec_windows.go
 signal_windows.go
env_windows.go:122: cannot use uint32(uintptr(unsafe.Pointer(argv))) (type uint3
2) as type syscall.Handle in function argument
make[1]: *** [_go_.8] Error 1
make[1]: Leaving directory `/c/handle/src/pkg/os'
make: *** [os.install] Error 1
make: Leaving directory `/c/handle/src/pkg'

Peter

[vcc, 2011-06-17 09:09:43]

PTAL

Thanks.

2011/6/17  <go.peter.90@gmail.com>:
> vcc,
>
> windows/386, hg id 12118c2a9829+ tip.
>
> ./all.bash
>
> install os
> INSTALL FAIL os
> make[1]: Entering directory `/c/handle/src/pkg/os'
> ./mkunixsignals.sh ../syscall/ztypes_windows_386.go > signal_windows.go
> || rm -f
>  signal_windows.go
> 8g  -o _go_.8 error.go env.go exec.go file.go getwd.go path.go proc.go
> stat_wind
> ows.go time.go types.go  dir_windows.go error_posix.go env_windows.go
> file_posix
> .go file_windows.go path_windows.go sys_windows.go exec_posix.go
> exec_windows.go
>  signal_windows.go
> env_windows.go:122: cannot use uint32(uintptr(unsafe.Pointer(argv)))
> (type uint3
> 2) as type syscall.Handle in function argument
> make[1]: *** [_go_.8] Error 1
> make[1]: Leaving directory `/c/handle/src/pkg/os'
> make: *** [os.install] Error 1
> make: Leaving directory `/c/handle/src/pkg'
>
> Peter
>
> http://codereview.appspot.com/4600042/
>

[rsc, 2011-06-20 19:27:58]

I think this is very close.

http://codereview.appspot.com/4600042/diff/31020/src/pkg/net/sock.go
File src/pkg/net/sock.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/net/sock.go#newcode53
src/pkg/net/sock.go:53: fd.sysfd = syscall.InvalidHandle
Can you make this

fd.close()
return nil, err

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/exec_posix.go
File src/pkg/os/exec_posix.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/exec_posix.go#new...
src/pkg/os/exec_posix.go:39: if f == nil {
Please drop this check and make f.Fd() do the check.
Then this line becomes

sysattr.Files = append(sysattr.Files, f.Fd())

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/file_windows.go
File src/pkg/os/file_windows.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/file_windows.go#n...
src/pkg/os/file_windows.go:22: // Fd returns the integer Unix file descriptor
referencing the open file.
s/integer Unix file descriptor/Windows handle/

http://codereview.appspot.com/4600042/diff/31020/src/pkg/syscall/syscall_unix.go
File src/pkg/syscall/syscall_unix.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/syscall/syscall_unix...
src/pkg/syscall/syscall_unix.go:12: type Handle int
I would like the non-Windows implementations to not know
about the name 'Handle'.  If you delete this line and also
the const InvalidHandle = -1 below, what breaks?

[vcc, 2011-06-21 04:30:41]

PTAL

http://codereview.appspot.com/4600042/diff/31020/src/pkg/net/sock.go
File src/pkg/net/sock.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/net/sock.go#newcode53
src/pkg/net/sock.go:53: fd.sysfd = syscall.InvalidHandle
On 2011/06/20 19:27:58, rsc wrote:
> Can you make this
> 
> fd.close()
> return nil, err

Done.

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/exec_posix.go
File src/pkg/os/exec_posix.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/exec_posix.go#new...
src/pkg/os/exec_posix.go:39: if f == nil {
On 2011/06/20 19:27:58, rsc wrote:
> Please drop this check and make f.Fd() do the check.
> Then this line becomes
> 
> sysattr.Files = append(sysattr.Files, f.Fd())

Done.

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/file_windows.go
File src/pkg/os/file_windows.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/os/file_windows.go#n...
src/pkg/os/file_windows.go:22: // Fd returns the integer Unix file descriptor
referencing the open file.
On 2011/06/20 19:27:58, rsc wrote:
> s/integer Unix file descriptor/Windows handle/

Done.

http://codereview.appspot.com/4600042/diff/31020/src/pkg/syscall/syscall_unix.go
File src/pkg/syscall/syscall_unix.go (right):

http://codereview.appspot.com/4600042/diff/31020/src/pkg/syscall/syscall_unix...
src/pkg/syscall/syscall_unix.go:12: type Handle int
On 2011/06/20 19:27:58, rsc wrote:
> I would like the non-Windows implementations to not know
> about the name 'Handle'.  If you delete this line and also
> the const InvalidHandle = -1 below, what breaks?
> 

After make syscall.InvalidHandle in net/sock.go and os/exec_posix.go gone, don't
need this.

[vcc, 2011-07-01 04:42:31]

ping

[mattn, 2011-07-01 05:06:01]

On 2011/07/01 04:42:31, vcc wrote:
> ping

I don't look the code. but ALL TESTS PASSED.

[rsc, 2011-07-01 14:17:58]

LGTM

[rsc, 2011-07-01 14:18:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=dc01810c2648 ***

windows: define and use syscall.Handle
Fixes issue 1487.

R=rsc, alex.brainman, go.peter.90, mikioh.mikioh, mattn.jp
CC=golang-dev
http://codereview.appspot.com/4600042

Committer: Russ Cox <rsc@golang.org>