code review 4589047: fmt: debugging formats for characters: %+q %#U

fmt: debugging formats for characters: %+q %#U
%+q uses strconv.Quote[Rune]ToASCII, guaranteeing ASCII-only output.
%#U a quoted character if the rune is printable: 'x'=U+0078; otherwise
it's as before: U+000A.

[r, 2011-06-10 06:17:16]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2011-06-10 17:06:55]

LGTM

http://codereview.appspot.com/4589047/diff/1/src/pkg/fmt/fmt_test.go
File src/pkg/fmt/fmt_test.go (right):

http://codereview.appspot.com/4589047/diff/1/src/pkg/fmt/fmt_test.go#newcode198
src/pkg/fmt/fmt_test.go:198: {"%#U", '\u263a', `'☺'=U+263A`},
I would prefer if %#U would always write the U+ first since it is always present
(with or w/o #), and add the printable char if possible (probably in parens):

U+263A
U+263A ('☺')

[rsc, 2011-06-10 17:37:07]

LGTM

The = jumbles things a bit.
It seems like you're trying to avoid a space
but I'm not sure that helps any: there will still
be a space in the output when printing U+0020.
I'm happy with Robert's output, also happy
with dropping the ():

U+00B7
U+00B7 '·'

Russ

[r, 2011-06-11 00:03:10]

*** Submitted as http://code.google.com/p/go/source/detail?r=cba21717c2a8 ***

fmt: debugging formats for characters: %+q %#U
%+q uses strconv.Quote[Rune]ToASCII, guaranteeing ASCII-only output.
%#U a quoted character if the rune is printable: 'x'=U+0078; otherwise
it's as before: U+000A.

R=golang-dev, gri, rsc
CC=golang-dev
http://codereview.appspot.com/4589047

[r2, 2011-06-11 00:04:05]

i tried both, went back and forth. i liked the parens but they're visually
noisier and take up more space, so i went with cleaner and parenless.

-rob