Issue 4589042: code review 4589042: runtime: fix Plan 9 "lingering goroutines bug".

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4589042: code review 4589042: runtime: fix Plan 9 "lingering goroutines bug". (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 4 months ago by paulzhol

Modified:
15 years, 4 months ago

Reviewers:

CC:
rsc, r, golang-dev

Visibility:
Public.

Description

runtime: fix Plan 9 "lingering goroutines bug".

Patch Set 1 : diff -r 9c605a1c54d8 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 2 : diff -r 9c605a1c54d8 https://go.googlecode.com/hg/ #

Created: 15 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -3 lines)			Patch
M	src/pkg/runtime/plan9/386/sys.s	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/plan9/os.h	View		2 chunks	+30 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/plan9/thread.c	View	1	1 chunk	+27 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

paulzhol

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

15 years, 4 months ago (2011-06-07 18:35:32 UTC) #1

rsc

http://codereview.appspot.com/4589042/diff/4001/src/pkg/runtime/plan9/thread.c File src/pkg/runtime/plan9/thread.c (right): http://codereview.appspot.com/4589042/diff/4001/src/pkg/runtime/plan9/thread.c#newcode44 src/pkg/runtime/plan9/thread.c:44: /* build path string /proc/pid/noteg */ notepg http://codereview.appspot.com/4589042/diff/4001/src/pkg/runtime/plan9/thread.c#newcode56 src/pkg/runtime/plan9/thread.c:56: ...

15 years, 4 months ago (2011-06-07 20:15:10 UTC) #2

paulzhol

Sorry for the typo's. The man for postnote says "For PNGROUP only, if the calling ...

15 years, 4 months ago (2011-06-07 20:23:46 UTC) #3

15 years, 4 months ago (2011-06-10 07:24:03 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=3180ac267d3d ***

runtime: fix Plan 9 "lingering goroutines bug".

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4589042

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages