Issue 4581041: Add functions for creating IBusConfig asynchronously.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4581041: Add functions for creating IBusConfig asynchronously. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by Peng

Modified:
14 years, 9 months ago

Reviewers:
yusukes, Yusuke Sato

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add functions for creating IBusConfig asynchronously. BUG=http://crosbug.com/13245 TEST=make check

Patch Set 2 : review fix #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -26 lines)			Patch
M	src/ibusconfig.h	View		1 chunk	+30 lines, -1 line	0 comments	Download
M	src/ibusconfig.c	View	1	8 chunks	+93 lines, -25 lines	0 comments	Download
M	src/tests/.gitignore	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/tests/Makefile.am	View		2 chunks	+4 lines, -0 lines	0 comments	Download
A	src/tests/ibus-config.c	View		1 chunk	+89 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

http://codereview.appspot.com/4581041/diff/1/src/ibusconfig.c File src/ibusconfig.c (right): http://codereview.appspot.com/4581041/diff/1/src/ibusconfig.c#newcode214 src/ibusconfig.c:214: return IBUS_CONFIG (object); Don't we have to call g_dbus_proxy_get_name_owner ...

14 years, 9 months ago (2011-06-07 05:05:52 UTC) #2

Peng

14 years, 9 months ago (2011-06-08 19:56:40 UTC) #3

yusukes

14 years, 9 months ago (2011-06-08 22:46:55 UTC) #4

On 2011/06/08 19:56:40, Peng wrote:
> http://codereview.appspot.com/4581041/diff/1/src/ibusconfig.c
> File src/ibusconfig.c (right):
> 
> http://codereview.appspot.com/4581041/diff/1/src/ibusconfig.c#newcode214
> src/ibusconfig.c:214: return IBUS_CONFIG (object);
> On 2011/06/07 05:05:52, Yusuke Sato wrote:
> > Don't we have to call g_dbus_proxy_get_name_owner here?
> > 
> > The synchronous version does it:
> > https://github.com/ibus/ibus/commit/61f0894c3555478117e9d5f286d0085bd5afdad3
> 
> Done.

lgtm

Expand All Messages | Collapse All Messages