Issue 4576044: Label caja.js frames for debugging convenience

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4576044: Label caja.js frames for debugging convenience (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by felix8a

Modified:
15 years, 5 months ago

Reviewers:
Jasvir, ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Chrome's debugger lets me examine the execution context of the current statement, but it's not always obvious what frame that's in. This change adds a className to caja's frames, which means I can type "frameElement.className" in the console to help identify the frame. The answer can be - "caja-taming-frame" - "caja-guest-frame" - some other string value for some non-caja frame. - frameElement undefined for the top-level window.

Patch Set 1 #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/com/google/caja/plugin/caja.js	View		3 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

@r4493

Expand All Messages | Collapse All Messages