Issue 4575053: code review 4575053: sync: add Semaphore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4575053: code review 4575053: sync: add Semaphore

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by kevlar

Modified:
11 years, 8 months ago

Reviewers:
khr, dave

CC:
golang-codereviews

Visibility:
Public.

Description

sync: add Semaphore There have been more and more questions about semaphore use cases on the mailing lists and on IRC. If we think it's a good idea (it's probably even easier to mishandle than mutexes), here is my attempt at a basic implementation.

Patch Set 1 #

Patch Set 2 : diff -r 3418f22c39eb https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3418f22c39eb https://go.googlecode.com/hg/ #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -0 lines)			Patch
M	src/pkg/sync/Makefile	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/pkg/sync/semaphore.go	View	1	1 chunk	+50 lines, -0 lines	0 comments	Download
A	src/pkg/sync/semaphore_test.go	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

kevlar

Hello iant@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 3 months ago (2011-06-08 16:26:10 UTC) #1

dave_cheney.net

11 years, 8 months ago (2014-01-01 23:53:06 UTC) #6

On 2013/12/20 16:26:20, gobot wrote:
> Replacing golang-dev with golang-codereviews.

R=close

Expand All Messages | Collapse All Messages