Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 4574042: code review 4574042: Port to Plan 9 Native: Changes to important header files. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by lucio
Modified:
14 years, 3 months ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

Port to Plan 9 Native: Changes to important header files. The "elf.h" header changes involve only comments, the released Plan 9 C preprocessing function does not cope with multiline comments following the #define keyword. All multiline comments have been moved to the line above the associated definition. Sigh! Fixing the Plan 9 compiler is not an option. <time.h> does not exist in the Plan 9 Native library. I have moved it from src/cmd/ld/pe.h to include/u.h. RSC correctly points out that this copy of <u.h> is not the one used to compile the Go release on Plan 9 platforms.

Patch Set 1 #

Patch Set 2 : diff -r 95448425041c https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0f1980acc591 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r e8891ae9fb04 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M include/u.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/cmd/ld/elf.h View 1 4 chunks +36 lines, -37 lines 0 comments Download

Messages

Total messages: 4
lucio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
14 years, 4 months ago (2011-06-04 05:03:17 UTC) #1
rsc
Please put <time.h> outside the conditional code, in the giant block that includes such files ...
14 years, 4 months ago (2011-06-07 18:32:14 UTC) #2
lucio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), Please take another look.
14 years, 3 months ago (2011-06-14 04:50:00 UTC) #3
rsc
14 years, 3 months ago (2011-06-14 18:14:13 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=8572c1b0cdcc ***

build: fix header files for Plan 9

The "elf.h" header changes involve only comments, the released
Plan 9 C preprocessing function does not cope with multiline
comments following the #define keyword.  All multiline comments
have been moved to the line above the associated definition.
Sigh!  Fixing the Plan 9 compiler is not an option.

<time.h> does not exist in the Plan 9 Native library.  I have
moved it from src/cmd/ld/pe.h to include/u.h. RSC correctly points
out that this copy of <u.h> is not the one used to compile the
Go release on Plan 9 platforms.

R=golang-dev
CC=golang-dev, rsc
http://codereview.appspot.com/4574042

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b