Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75)

Issue 4572065: code review 4572065: godoc: replace direct OS file system accesses in favor (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by gri
Modified:
9 years, 7 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

godoc: replace direct OS file system accesses in favor of accesses via a FileSystem interface. Preparation for appengine version which gets its files via a snapshot or zip file and uses a corresponding FileSystem implementation.

Patch Set 1 #

Patch Set 2 : diff -r ecb31be11487 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ecb31be11487 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ecb31be11487 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r ecb31be11487 https://go.googlecode.com/hg/ #

Total comments: 10

Patch Set 6 : diff -r d086bab9b037 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r d086bab9b037 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -69 lines) Patch
M src/cmd/godoc/Makefile View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/cmd/godoc/codewalk.go View 1 2 3 4 5 9 chunks +15 lines, -15 lines 0 comments Download
M src/cmd/godoc/dirtrees.go View 1 7 chunks +19 lines, -18 lines 0 comments Download
A src/cmd/godoc/filesystem.go View 1 2 3 4 5 1 chunk +96 lines, -0 lines 0 comments Download
M src/cmd/godoc/godoc.go View 1 2 3 10 chunks +20 lines, -27 lines 0 comments Download
M src/cmd/godoc/index.go View 1 2 3 4 5 5 chunks +5 lines, -6 lines 0 comments Download
M src/cmd/godoc/main.go View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/godoc/mapping.go View 1 2 chunks +1 line, -2 lines 0 comments Download
A src/cmd/godoc/parser.go View 1 2 1 chunk +69 lines, -0 lines 0 comments Download
M src/cmd/godoc/utils.go View 1 2 3 4 5 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
gri
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 7 months ago (2011-06-15 00:57:14 UTC) #1
rsc
http://codereview.appspot.com/4572065/diff/5001/src/cmd/godoc/filesystem.go File src/cmd/godoc/filesystem.go (right): http://codereview.appspot.com/4572065/diff/5001/src/cmd/godoc/filesystem.go#newcode17 src/cmd/godoc/filesystem.go:17: type FileInfo interface { I don't believe this makes ...
9 years, 7 months ago (2011-06-15 02:46:47 UTC) #2
gri
PTAL http://codereview.appspot.com/4572065/diff/5001/src/cmd/godoc/filesystem.go File src/cmd/godoc/filesystem.go (right): http://codereview.appspot.com/4572065/diff/5001/src/cmd/godoc/filesystem.go#newcode17 src/cmd/godoc/filesystem.go:17: type FileInfo interface { On 2011/06/15 02:46:47, rsc ...
9 years, 7 months ago (2011-06-15 20:12:03 UTC) #3
rsc
LGTM
9 years, 7 months ago (2011-06-15 20:31:26 UTC) #4
gri
9 years, 7 months ago (2011-06-15 21:06:44 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=3a5f42c956e0 ***

godoc: replace direct OS file system accesses in favor
       of accesses via a FileSystem interface.

Preparation for appengine version which gets its files
via a snapshot or zip file and uses a corresponding
FileSystem implementation.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/4572065
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b