src/pkg/go/scanner/scanner_test.go - Issue 4572049: code review 4572049: go/scanner: partially revert CL4538096 now that we have...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/go/scanner/scanner_test.go

Issue 4572049: code review 4572049: go/scanner: partially revert CL4538096 now that we have... (Closed)

Patch Set: diff -r 2fb655410b1a https://go.googlecode.com/hg/ Created 13 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/go/scanner/scanner_test.go

===================================================================

--- a/src/pkg/go/scanner/scanner_test.go

+++ b/src/pkg/go/scanner/scanner_test.go

@@ -650,9 +650,9 @@

pos int

err string

}{

- {"\a", token.ILLEGAL, 0, "illegal character '\\a'"},

- {`#`, token.ILLEGAL, 0, "illegal character '#'"},

- {`…`, token.ILLEGAL, 0, "illegal character '…'"},

+ {"\a", token.ILLEGAL, 0, "illegal character U+0007"},

+ {`#`, token.ILLEGAL, 0, "illegal character U+0023 '#'"},

+ {`…`, token.ILLEGAL, 0, "illegal character U+2026 '…'"},

{`' '`, token.CHAR, 0, ""},

{`''`, token.CHAR, 0, "illegal character literal"},

{`'\8'`, token.CHAR, 2, "unknown escape sequence"},

« no previous file with comments | « src/pkg/go/scanner/scanner.go ('k') | no next file » | no next file with comments »