src/cmd/godefs/stabs.c - Issue 4564043: code review 4564043: godefs: do not assume forward type references are enums

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: src/cmd/godefs/stabs.c

Issue 4564043: code review 4564043: godefs: do not assume forward type references are enums (Closed)

Left Patch Set: diff -r 798775ed7ee3 https://go.googlecode.com/hg/ Created 13 years, 10 months ago

Right Patch Set: diff -r 3bbbb59986c7 https://go.googlecode.com/hg/ Created 13 years, 10 months ago

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
(Both sides are equal)
1 // Copyright 2009 The Go Authors. All rights reserved.	1 // Copyright 2009 The Go Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style	2 // Use of this source code is governed by a BSD-style

3 // license that can be found in the LICENSE file.	3 // license that can be found in the LICENSE file.

4	4

5 // Parse stabs debug info.	5 // Parse stabs debug info.

6	6

7 #include "a.h"	7 #include "a.h"

8	8

9 int stabsdebug = 1;	9 int stabsdebug = 1;

10	10

(...skipping 436 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
447	447

448 // parse the definition.	448 // parse the definition.

449 if(name[0] == '\0')	449 if(name[0] == '\0')

450 name = nil;	450 name = nil;

451 if(parsedef(&p, name) == nil)	451 if(parsedef(&p, name) == nil)

452 goto Bad;	452 goto Bad;

453 if(*p != '\0')	453 if(*p != '\0')

454 goto Bad;	454 goto Bad;

455 }	455 }

456	456

LEFT	RIGHT