Issue 4551052: Add a param to the request in CacheEnforcementVisitor to signify its an async request

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4551052: Add a param to the request in CacheEnforcementVisitor to signify its an async request

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 9 months ago by nikhilmadan23

Modified:
14 years, 9 months ago

Reviewers:
gagan.goku, satya3656, pradnya, dev-remailer

CC:
cool-shindig-committers_googlegroups.com

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This change adds a param to the HttpRequest in CacheEnforcementVisitor to indicate that this fetch is an asynchronous fetch spawned by the CacheEnforcementVisitor.

Patch Set 1 #

Created: 14 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
		java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitor.java	View		2 chunks	+2 lines, -0 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/rewrite/CacheEnforcementVisitorTest.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gagan.goku

On 2011/05/23 06:42:50, pradnya wrote: > LGTM > > Can you send the review to ...

14 years, 9 months ago (2011-05-23 07:24:04 UTC) #4

nikhilmadan23

Thanks. We need this change quite urgently. I'd be grateful if you could commit it ...

14 years, 9 months ago (2011-05-23 07:26:22 UTC) #5

Build looks good.
Committed as r1126359.

Expand All Messages | Collapse All Messages