Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(310)

Issue 4550112: code review 4550112: http: don't fail on accept hitting EMFILE (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by bradfitz
Modified:
11 years, 2 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

http: don't fail on accept hitting EMFILE Fixes issue 1891

Patch Set 1 #

Patch Set 2 : diff -r 85edd97537ba https://go.googlecode.com/hg #

Patch Set 3 : diff -r 85edd97537ba https://go.googlecode.com/hg #

Patch Set 4 : diff -r 9f4046737460 https://go.googlecode.com/hg/ #

Total comments: 4

Patch Set 5 : diff -r 9f4046737460 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r 472fb089eaab https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
M src/pkg/http/serve_test.go View 1 2 3 2 chunks +37 lines, -0 lines 0 comments Download
M src/pkg/http/server.go View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/pkg/os/error_posix.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg
11 years, 2 months ago (2011-06-02 21:55:37 UTC) #1
bradfitz
R=iant too Typed rsc out of muscle memory, but several people besides me probably know ...
11 years, 2 months ago (2011-06-02 21:57:37 UTC) #2
rsc
The correct fix is to edit the definition of Errno.Temporary in package os. Then check ...
11 years, 2 months ago (2011-06-03 01:46:00 UTC) #3
bradfitz
Oh, hadn't seem that. Done. On Thu, Jun 2, 2011 at 6:45 PM, Russ Cox ...
11 years, 2 months ago (2011-06-03 19:04:06 UTC) #4
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2011-06-03 19:04:12 UTC) #5
rsc
http://codereview.appspot.com/4550112/diff/8001/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/4550112/diff/8001/src/pkg/http/server.go#newcode851 src/pkg/http/server.go:851: func errorIsTemporary(err os.Error) bool { delete http://codereview.appspot.com/4550112/diff/8001/src/pkg/http/server.go#newcode872 src/pkg/http/server.go:872: if ...
11 years, 2 months ago (2011-06-03 19:05:55 UTC) #6
rsc
http://codereview.appspot.com/4550112/diff/8001/src/pkg/http/server.go File src/pkg/http/server.go (right): http://codereview.appspot.com/4550112/diff/8001/src/pkg/http/server.go#newcode872 src/pkg/http/server.go:872: if errorIsTemporary(e) { On 2011/06/03 19:05:55, rsc wrote: > ...
11 years, 2 months ago (2011-06-03 19:06:41 UTC) #7
bradfitz
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 2 months ago (2011-06-03 19:10:41 UTC) #8
rsc
LGTM
11 years, 2 months ago (2011-06-03 19:15:17 UTC) #9
bradfitz
11 years, 2 months ago (2011-06-03 19:24:01 UTC) #10
*** Submitted as http://code.google.com/p/go/source/detail?r=95448425041c ***

http: don't fail on accept hitting EMFILE

Fixes issue 1891

R=rsc
CC=golang-dev
http://codereview.appspot.com/4550112
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b