Issue 4540042: Further refactoring for core dom and string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4540042: Further refactoring for core dom and string

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by mhermanto

Modified:
14 years, 10 months ago

Reviewers:
johnfargo, fargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+123 lines, -120 lines)			Patch
features/pom.xml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.util.dom/dom.js	View	1 chunk	+1 line, -1 line	0 comments	Download
features/src/main/javascript/features/core.util.string/feature.xml	View	1 chunk	+2 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.util.string/string.js	View	2 chunks	+106 lines, -1 line	1 comment	Download
features/src/main/javascript/features/core.util.string/taming.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
features/src/main/javascript/features/core.util/feature.xml	View	1 chunk	+0 lines, -3 lines	0 comments	Download
features/src/main/javascript/features/core.util/taming.js	View	1 chunk	+0 lines, -2 lines	0 comments	Download
features/src/main/javascript/features/core.util/util.js	View	2 chunks	+9 lines, -112 lines	0 comments	Download
features/src/main/javascript/features/features.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

johnfargo

LGTM http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/features/core.util.string/string.js File features/src/main/javascript/features/core.util.string/string.js (right): http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/features/core.util.string/string.js#newcode121 features/src/main/javascript/features/core.util.string/string.js:121: // TODO: move to core.util.string. remove todo

14 years, 10 months ago (2011-05-11 06:48:12 UTC) #2

mhermanto

14 years, 10 months ago (2011-05-11 06:59:56 UTC) #3

Done.

On Tue, May 10, 2011 at 11:48 PM, <johnfargo@gmail.com> wrote:

> LGTM
>
>
>
>
http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/fea...
> File features/src/main/javascript/features/core.util.string/string.js
> (right):
>
>
>
http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/core.util.string/string.js:121: //
> TODO: move to core.util.string.
> remove todo
>
>
> http://codereview.appspot.com/4540042/
>

Expand All Messages | Collapse All Messages