Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(216)

Issue 4540042: Further refactoring for core dom and string

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by mhermanto
Modified:
14 years, 10 months ago
Reviewers:
johnfargo, fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

... and fix string concat.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -120 lines) Patch
features/pom.xml View 1 chunk +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/core.util.dom/dom.js View 1 chunk +1 line, -1 line 0 comments Download
features/src/main/javascript/features/core.util.string/feature.xml View 1 chunk +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/core.util.string/string.js View 2 chunks +106 lines, -1 line 1 comment Download
features/src/main/javascript/features/core.util.string/taming.js View 1 chunk +2 lines, -0 lines 0 comments Download
features/src/main/javascript/features/core.util/feature.xml View 1 chunk +0 lines, -3 lines 0 comments Download
features/src/main/javascript/features/core.util/taming.js View 1 chunk +0 lines, -2 lines 0 comments Download
features/src/main/javascript/features/core.util/util.js View 2 chunks +9 lines, -112 lines 0 comments Download
features/src/main/javascript/features/features.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mhermanto
14 years, 10 months ago (2011-05-11 06:40:14 UTC) #1
johnfargo
LGTM http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/features/core.util.string/string.js File features/src/main/javascript/features/core.util.string/string.js (right): http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/features/core.util.string/string.js#newcode121 features/src/main/javascript/features/core.util.string/string.js:121: // TODO: move to core.util.string. remove todo
14 years, 10 months ago (2011-05-11 06:48:12 UTC) #2
mhermanto
14 years, 10 months ago (2011-05-11 06:59:56 UTC) #3
Done.

On Tue, May 10, 2011 at 11:48 PM, <johnfargo@gmail.com> wrote:

> LGTM
>
>
>
>
http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/fea...
> File features/src/main/javascript/features/core.util.string/string.js
> (right):
>
>
>
http://codereview.appspot.com/4540042/diff/1/features/src/main/javascript/fea...
> features/src/main/javascript/features/core.util.string/string.js:121: //
> TODO: move to core.util.string.
> remove todo
>
>
> http://codereview.appspot.com/4540042/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b