Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4539095: Parameterizing LongLivedReferesh value in ConcatProxyServlet & ProxyHandler (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 9 months ago by pulkitgoyal2000
Modified:
14 years, 9 months ago
Reviewers:
gagan.goku, dev-remailer
CC:
cool-shindig-committers_googlegroups.com, nikhilmadan23, pradnya
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Parameterizing LongLivedRefresh value in ConcatProxyServlet & ProxyHandler so that one can control its value via shindig.properties.

Patch Set 1 #

Patch Set 2 : Adding Comment in shindig.properties #

Patch Set 3 : Little Refinement #

Patch Set 4 : Addressing Comments #

Total comments: 2

Patch Set 5 : Addressing Nikhil's Comment #

Total comments: 4

Patch Set 6 : Addressing Pradnya's Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
java/common/conf/shindig.properties View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java View 1 2 3 4 5 3 chunks +9 lines, -2 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyHandlerTest.java View 1 4 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 9
pulkitgoyal2000
14 years, 9 months ago (2011-05-30 09:40:35 UTC) #1
pulkitgoyal2000
Addressing Comments
14 years, 9 months ago (2011-05-30 11:50:58 UTC) #2
nikhilmadan23
lgtm http://codereview.appspot.com/4539095/diff/14001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java (right): http://codereview.appspot.com/4539095/diff/14001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java#newcode51 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:51: static final Integer LONG_LIVED_REFRESH = (365 * 24 ...
14 years, 9 months ago (2011-05-30 12:23:34 UTC) #3
pulkitgoyal2000
http://codereview.appspot.com/4539095/diff/14001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java (right): http://codereview.appspot.com/4539095/diff/14001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java#newcode51 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java:51: static final Integer LONG_LIVED_REFRESH = (365 * 24 * ...
14 years, 9 months ago (2011-05-30 12:49:04 UTC) #4
pradnya
http://codereview.appspot.com/4539095/diff/16001/java/common/conf/shindig.properties File java/common/conf/shindig.properties (right): http://codereview.appspot.com/4539095/diff/16001/java/common/conf/shindig.properties#newcode176 java/common/conf/shindig.properties:176: org.apache.shindig.gadgets.servlet.longLivedRefresh=31536000 can you call this longLivedRefreshSec http://codereview.appspot.com/4539095/diff/16001/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java ...
14 years, 9 months ago (2011-05-30 16:59:04 UTC) #5
pulkitgoyal2000
http://codereview.appspot.com/4539095/diff/16001/java/common/conf/shindig.properties File java/common/conf/shindig.properties (right): http://codereview.appspot.com/4539095/diff/16001/java/common/conf/shindig.properties#newcode176 java/common/conf/shindig.properties:176: org.apache.shindig.gadgets.servlet.longLivedRefresh=31536000 On 2011/05/30 16:59:04, pradnya wrote: > can you ...
14 years, 9 months ago (2011-05-30 17:34:02 UTC) #6
gagan.goku
lgtm
14 years, 9 months ago (2011-06-01 04:28:35 UTC) #7
gagan.goku
On 2011/06/01 04:28:35, gagan.goku wrote: > lgtm Thanks for verifying tests with mvn 3 Submitting ...
14 years, 9 months ago (2011-06-08 04:53:19 UTC) #8
gagan.goku
14 years, 9 months ago (2011-06-08 04:54:21 UTC) #9 
Build looks good.
Committed as r1133248.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b