Issue 4538077: code review 4538077: image/jpeg: small memory layout optimization for encoding.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4538077: code review 4538077: image/jpeg: small memory layout optimization for encoding. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by nigeltao

Modified:
14 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

image/jpeg: small memory layout optimization for encoding. Before: jpeg.BenchmarkEncodeRGBOpaque ... 23.29 MB/s jpeg.BenchmarkEncodeRGBOpaque ... 23.27 MB/s jpeg.BenchmarkEncodeRGBOpaque ... 23.17 MB/s After: jpeg.BenchmarkEncodeRGBOpaque ... 23.42 MB/s jpeg.BenchmarkEncodeRGBOpaque ... 23.34 MB/s jpeg.BenchmarkEncodeRGBOpaque ... 23.33 MB/s

Patch Set 1 #

Patch Set 2 : diff -r bf7512d859d5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bf7512d859d5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ca3f8ce83f2b https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	src/pkg/image/jpeg/writer.go	View	1	4 chunks	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-18 21:20:20 UTC) #1

rsc

LGTM I found this because of the unaligned access. It wasn't (and still isn't) being ...

14 years ago (2011-05-18 21:24:26 UTC) #2

nigeltao

14 years ago (2011-05-18 21:39:41 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=31f1d1d54f4c ***

image/jpeg: small memory layout optimization for encoding.

Before:
jpeg.BenchmarkEncodeRGBOpaque ... 23.29 MB/s
jpeg.BenchmarkEncodeRGBOpaque ... 23.27 MB/s
jpeg.BenchmarkEncodeRGBOpaque ... 23.17 MB/s

After:
jpeg.BenchmarkEncodeRGBOpaque ... 23.42 MB/s
jpeg.BenchmarkEncodeRGBOpaque ... 23.34 MB/s
jpeg.BenchmarkEncodeRGBOpaque ... 23.33 MB/s

R=rsc
CC=golang-dev
http://codereview.appspot.com/4538077

Expand All Messages | Collapse All Messages