Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(258)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4538045: (Start of) breaking up core.util into core.util.dom and core.util.string

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by mhermanto
Modified:
14 years, 10 months ago
Reviewers:
johnfargo, fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow-up CL #

Messages

Total messages: 5
mhermanto
14 years, 10 months ago (2011-05-10 02:42:15 UTC) #1
johnfargo
http://codereview.appspot.com/4538045/diff/1/features/src/main/javascript/features/core.util.dom/dom.js File features/src/main/javascript/features/core.util.dom/dom.js (right): http://codereview.appspot.com/4538045/diff/1/features/src/main/javascript/features/core.util.dom/dom.js#newcode39 features/src/main/javascript/features/core.util.dom/dom.js:39: // TODO: factor this out to core.util.dom. remove this ...
14 years, 10 months ago (2011-05-10 02:44:59 UTC) #2
johnfargo
LGTM otherwise On 2011/05/10 02:44:59, johnfargo wrote: > http://codereview.appspot.com/4538045/diff/1/features/src/main/javascript/features/core.util.dom/dom.js > File features/src/main/javascript/features/core.util.dom/dom.js (right): > > ...
14 years, 10 months ago (2011-05-10 02:45:08 UTC) #3
mhermanto
Done. On Mon, May 9, 2011 at 7:45 PM, <johnfargo@gmail.com> wrote: > LGTM otherwise > ...
14 years, 10 months ago (2011-05-10 02:47:20 UTC) #4
mhermanto
14 years, 10 months ago (2011-05-10 03:21:06 UTC) #5 
Follow-up CL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b