Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 45320043: New Simple applications (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by Tommaso Pecorella
Modified:
7 years, 2 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

New Simple applications

Patch Set 1 #

Patch Set 2 : Add example and test #

Total comments: 9

Patch Set 3 : Fix Tom's comments #

Patch Set 4 : More doc clarification #

Patch Set 5 : Clarification by example #

Patch Set 6 : Renaming #

Patch Set 7 : Nothing is ever perfect #

Patch Set 8 : Small changes to allow infinite sending #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+737 lines, -16 lines) Patch
A src/network/examples/packet-socket-apps.cc View 1 2 3 4 5 6 1 chunk +98 lines, -0 lines 0 comments Download
M src/network/examples/wscript View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
A src/network/test/simple-apps-test-suite.cc View 1 2 3 4 5 6 7 1 chunk +122 lines, -0 lines 2 comments Download
A src/network/utils/packet-socket-client.h View 1 2 3 4 5 6 1 chunk +100 lines, -0 lines 0 comments Download
A src/network/utils/packet-socket-client.cc View 1 2 3 4 5 6 7 1 chunk +155 lines, -0 lines 1 comment Download
A src/network/utils/packet-socket-server.h View 1 2 3 4 5 6 1 chunk +92 lines, -0 lines 0 comments Download
A src/network/utils/packet-socket-server.cc View 1 2 3 4 5 6 1 chunk +129 lines, -0 lines 0 comments Download
M src/network/utils/simple-net-device.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/network/wscript View 1 2 3 4 5 3 chunks +5 lines, -0 lines 0 comments Download
M src/spectrum/test/spectrum-ideal-phy-test.cc View 1 2 3 4 5 6 7 2 chunks +9 lines, -8 lines 0 comments Download
M src/spectrum/wscript View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/wave/test/ocb-test-suite.cc View 1 2 3 4 5 6 2 chunks +13 lines, -6 lines 0 comments Download
M src/wave/wscript View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15
Tommaso Pecorella
7 years, 7 months ago (2014-04-05 20:05:53 UTC) #1
Tommaso Pecorella
Test and example application added. Valgrind tests are fine. T.
7 years, 7 months ago (2014-04-05 20:40:01 UTC) #2
Tom Henderson
My main comment is that it isn't clear to me whether this will work on ...
7 years, 7 months ago (2014-04-11 13:51:28 UTC) #3
Tommaso Pecorella
7 years, 7 months ago (2014-04-12 12:44:59 UTC) #4
Tommaso Pecorella
7 years, 7 months ago (2014-04-12 12:58:16 UTC) #5
Tommaso Pecorella
On 2014/04/11 13:51:28, Tom Henderson wrote: > My main comment is that it isn't clear ...
7 years, 7 months ago (2014-04-12 12:58:32 UTC) #6
Tom Henderson
On 2014/04/12 12:58:32, Tommaso Pecorella wrote: > On 2014/04/11 13:51:28, Tom Henderson wrote: > > ...
7 years, 7 months ago (2014-04-12 23:30:50 UTC) #7
Tommaso Pecorella
7 years, 7 months ago (2014-04-13 11:22:05 UTC) #8
Tommaso Pecorella
On 2014/04/12 23:30:50, Tom Henderson wrote: > On 2014/04/12 12:58:32, Tommaso Pecorella wrote: > > ...
7 years, 7 months ago (2014-04-13 11:26:46 UTC) #9
Tom Henderson
On 2014/04/13 11:26:46, Tommaso Pecorella wrote: > On 2014/04/12 23:30:50, Tom Henderson wrote: > > ...
7 years, 7 months ago (2014-04-13 18:19:32 UTC) #10
Tommaso Pecorella
On 2014/04/13 18:19:32, Tom Henderson wrote: > > > > The real reason I did ...
7 years, 7 months ago (2014-04-13 18:21:47 UTC) #11
Tommaso Pecorella
7 years, 7 months ago (2014-04-13 18:55:22 UTC) #12
Tommaso Pecorella
7 years, 7 months ago (2014-04-19 10:07:43 UTC) #13
Tommaso Pecorella
7 years, 4 months ago (2014-07-27 21:54:58 UTC) #14
Tom Henderson
7 years, 2 months ago (2014-09-09 20:36:29 UTC) #15
At this point, just a couple trivial comments; I think this is ready for merge.

https://codereview.appspot.com/45320043/diff/120001/src/network/test/simple-a...
File src/network/test/simple-apps-test-suite.cc (right):

https://codereview.appspot.com/45320043/diff/120001/src/network/test/simple-a...
src/network/test/simple-apps-test-suite.cc:23: #include "ns3/network-module.h"
do not use "-module" variants here

https://codereview.appspot.com/45320043/diff/120001/src/network/test/simple-a...
src/network/test/simple-apps-test-suite.cc:108: Simulator::Destroy ();
redundant Destroy() statements.

https://codereview.appspot.com/45320043/diff/120001/src/network/utils/packet-...
File src/network/utils/packet-socket-client.cc (right):

https://codereview.appspot.com/45320043/diff/120001/src/network/utils/packet-...
src/network/utils/packet-socket-client.cc:100: NS_ASSERT_MSG (m_peerAddressSet,
"Local address not set");
peer address not set
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b