enable closure compiler to work with v2 and higher sourcemap formats

[vinny, 2011-05-31 09:08:26]

Hi guys,
I'd appreciate your comments on this diff to enable parsing of v2 sourcemaps.
I'm also open to generic comments on these components.

thanks,
Vinny

[zhoresh, 2011-06-01 17:40:26]

Look very good, mostly nit.
Please also verify with the profiler in ggs.

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
File
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
(right):

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:86:
CompilerOptions getCompilerOptions(JsUri uri) {
I think it should still be protected so it can be overloaded.

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:114:
@Override
Since shindig need to still support java 1.5 we should not add Override when
implementing interface

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:235:
@Override
Same

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:293:
return null;
nit; you can consolidate the return null

http://codereview.appspot.com/4530086/diff/1/src/test/java16/org/apache/shind...
File
src/test/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompilerTest.java
(right):

http://codereview.appspot.com/4530086/diff/1/src/test/java16/org/apache/shind...
src/test/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompilerTest.java:281:
@Override
same

[vinny, 2011-06-01 18:24:58]

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
File
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java
(right):

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:86:
CompilerOptions getCompilerOptions(JsUri uri) {
On 2011/06/01 17:40:26, zhoresh wrote:
> I think it should still be protected so it can be overloaded.

Done.

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:114:
@Override
On 2011/06/01 17:40:26, zhoresh wrote:
> Since shindig need to still support java 1.5 we should not add Override when
> implementing interface
I thought the java6 profile tag would prevent these files from being included in
a machine that only supports java 1.5.
I have removed all instances of the Override annotation. thanks,

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:235:
@Override
On 2011/06/01 17:40:26, zhoresh wrote:
> Same

Done.

http://codereview.appspot.com/4530086/diff/1/src/main/java16/org/apache/shind...
src/main/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompiler.java:293:
return null;
On 2011/06/01 17:40:26, zhoresh wrote:
> nit; you can consolidate the return null

Done.

http://codereview.appspot.com/4530086/diff/1/src/test/java16/org/apache/shind...
File
src/test/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompilerTest.java
(right):

http://codereview.appspot.com/4530086/diff/1/src/test/java16/org/apache/shind...
src/test/java16/org/apache/shindig/gadgets/rewrite/js/ClosureJsCompilerTest.java:281:
@Override
On 2011/06/01 17:40:26, zhoresh wrote:
> same

Done.

[zhoresh, 2011-06-13 21:35:59]

LGTM

Thanks!

Just one (obvious) note - the mapping only reference code that show up in the
compiled result, code and even a file that was compiled out will not show up in
the map.

Will commit if there are no objection.

[zhoresh, 2011-06-15 20:03:06]

Sorry for the delay.
Submitted to r1136164