Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 4530056: neuter appengine http proxy cache (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by felix8a
Modified:
15 years, 5 months ago
Reviewers:
Jasvir
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

appengine has an http proxy cache that makes it annoying to use the caja playground there. if you modify the contents at a url, it can take several minutes before the change is visible to the playground, and which version the playground gets can vary depending on which instance of the proxy cache happens to answer the request. this change reduces the annoyance by sending a Cache-Control header with the playground's url fetches, which is honored by the proxy cache. I tested this by manually uploading before/after versions to a test app at appengine, and manually fiddling with them, verifying that the "before" version notices changes slowly and inconsistently, but the "after" version notices changes quickly and consistently.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java View 1 chunk +0 lines, -1 line 0 comments Download
M src/com/google/caja/demos/playground/server/GWTCajolingServiceImpl.java View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 4
felix8a
15 years, 5 months ago (2011-05-19 08:37:08 UTC) #1
felix8a
ping
15 years, 5 months ago (2011-06-06 22:56:52 UTC) #2
Jasvir
LGTM
15 years, 5 months ago (2011-06-06 23:03:40 UTC) #3
felix8a
15 years, 5 months ago (2011-06-06 23:08:04 UTC) #4
@r4495
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b