LGTM Thx! On Thu, May 19, 2011 at 3:44 PM, <mhermanto@gmail.com> wrote: > Reviewers: fargo, > > > > Please review this at http://codereview.appspot.com/4523085/ > > Affected files: > features/pom.xml > features/src/main/javascript/features/osapi/feature.xml > features/src/main/javascript/features/osapi/gadgetsrpctransport.js > features/src/test/javascript/features/alltests.js > > > ### Eclipse Workspace Patch 1.0 > #P shindig-project > Index: features/src/main/javascript/features/osapi/feature.xml > =================================================================== > --- features/src/main/javascript/features/osapi/feature.xml (revision > 1125142) > +++ features/src/main/javascript/features/osapi/feature.xml (working > copy) > @@ -29,10 +29,15 @@ > <dependency>osapi.base</dependency> > <dependency>rpc</dependency> > <dependency>security-token</dependency> > - <all> > + <container> > + <script src="jsonrpctransport.js"></script> > + <script src="peoplehelpers.js"></script> > + <script src="taming.js" caja="1"></script> > + </container> > + <gadget> > <script src="jsonrpctransport.js"></script> > <script src="gadgetsrpctransport.js"></script> > <script src="peoplehelpers.js"></script> > <script src="taming.js" caja="1"></script> > - </all> > + </gadget> > </feature> > Index: features/src/main/javascript/features/osapi/gadgetsrpctransport.js > =================================================================== > --- features/src/main/javascript/features/osapi/gadgetsrpctransport.js > (revision 1125142) > +++ features/src/main/javascript/features/osapi/gadgetsrpctransport.js > (working copy) > @@ -115,7 +115,7 @@ > } > > // Do not run this in container mode. > - if (gadgets.config && window !== window.top) { > + if (gadgets.config) { > gadgets.config.register('osapi.services', null, init); > } > })(); > Index: features/pom.xml > =================================================================== > --- features/pom.xml (revision 1125142) > +++ features/pom.xml (working copy) > @@ -108,8 +108,6 @@ > <source>globals/globals.js</source> > <source>cloo/cloo.js</source> > <source>core.config.base/config.js</source> > - <source>core.config.base/configcontainer.js</source> > - <source>core.config.base/configgadget.js</source> > <source>core.config/validators.js</source> > <source>core.json/json-native.js</source> > <source>core.json/json-jsimpl.js</source> > Index: features/src/test/javascript/features/alltests.js > =================================================================== > --- features/src/test/javascript/features/alltests.js (revision 1125142) > +++ features/src/test/javascript/features/alltests.js (working copy) > @@ -39,8 +39,6 @@ > eval(JsUtil.prototype.include(srcDir + '/globals/globals.js')); > eval(JsUtil.prototype.include(srcDir + '/cloo/cloo.js')); > eval(JsUtil.prototype.include(srcDir + '/core.config.base/config.js')); > - eval(JsUtil.prototype.include(srcDir + > '/core.config.base/configcontainer.js')); > - eval(JsUtil.prototype.include(srcDir + > '/core.config.base/configgadget.js')); > eval(JsUtil.prototype.include(srcDir + '/core.config/validators.js')); > eval(JsUtil.prototype.include(srcDir + '/core.json/json-native.js')); > eval(JsUtil.prototype.include(srcDir + '/core.json/json-jsimpl.js')); > > >
