arch/socppc/dev/wdc_mainbus.c - Issue 4521049: Refactor channel_queue allocation and initialization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: arch/socppc/dev/wdc_mainbus.c

Issue 4521049: Refactor channel_queue allocation and initialization

Patch Set: Add analogous wdc_free_queue() function Created 13 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: arch/socppc/dev/wdc_mainbus.c

===================================================================

RCS file: /home/mdempsky/anoncvs/cvs/src/sys/arch/socppc/dev/wdc_mainbus.c,v

retrieving revision 1.1

diff -u -r1.1 wdc_mainbus.c

--- arch/socppc/dev/wdc_mainbus.c 6 Sep 2009 20:09:34 -0000 1.1

+++ arch/socppc/dev/wdc_mainbus.c 8 May 2011 21:13:29 -0000

@@ -132,10 +132,9 @@

chp->channel = 0;

chp->wdc = &sc->sc_wdcdev;

- chp->ch_queue = malloc(sizeof(struct channel_queue), M_DEVBUF,

- M_NOWAIT);

+ chp->ch_queue = wdc_alloc_queue();

if (chp->ch_queue == NULL) {

- printf("%s: can't allocate memory for command queue\n",

+ printf("%s: cannot allocate channel queue\n",

self->dv_xname);

/* XXX disestablish interrupt */

return;

« no previous file with comments | « arch/palm/dev/palm_hdd.c ('k') | dev/ic/wdc.c » ('j') | no next file with comments »