Issue 4517059: Force compilation and anon-func processor to run

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4517059: Force compilation and anon-func processor to run (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by mhermanto

Modified:
14 years, 10 months ago

Reviewers:
zhoresh

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This will allow loader JS (which breaks out of pipeline of processor early) to be compiled as well.

Patch Set 1 #

Total comments: 1

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+39 lines, -14 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java	View	2 chunks	+13 lines, -4 lines	1 comment	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsServingPipelineModule.java	View	4 chunks	+13 lines, -5 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistryTest.java	View	7 chunks	+11 lines, -4 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/JsServletTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

zhoresh

LGTM http://codereview.appspot.com/4517059/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java (right): http://codereview.appspot.com/4517059/diff/1/java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java#newcode47 java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java:47: break; This break is the key, you still ...

14 years, 10 months ago (2011-05-12 22:38:34 UTC) #2

mhermanto

14 years, 10 months ago (2011-05-12 22:45:08 UTC) #3

Thanks. Done.

On Thu, May 12, 2011 at 3:38 PM, <zhoresh@gmail.com> wrote:

> LGTM
>
>
>
>
>
http://codereview.appspot.com/4517059/diff/1/java/gadgets/src/main/java/org/a...
> File
>
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java
> (right):
>
>
>
http://codereview.appspot.com/4517059/diff/1/java/gadgets/src/main/java/org/a...
>
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java:47:
> break;
> This break is the key, you still want to run the required processors
> even if the process was stopped.
> Please add a small comment for that effect
>
>
> http://codereview.appspot.com/4517059/
>

Expand All Messages | Collapse All Messages