Issue 4515155: code review 4515155: http: client+server benchmark

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515155: code review 4515155: http: client+server benchmark (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by bradfitz

Modified:
13 years, 10 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

http: client+server benchmark baseline runs: (6g, gopher.mtv) http_test.BenchmarkClientServer 5000 412588 ns/op http_test.BenchmarkClientServer 5000 403346 ns/op http_test.BenchmarkClientServer 5000 413936 ns/op http_test.BenchmarkClientServer 5000 410287 ns/op http_test.BenchmarkClientServer 5000 388037 ns/op http_test.BenchmarkClientServer 5000 405545 ns/op http_test.BenchmarkClientServer 5000 405179 ns/op http_test.BenchmarkClientServer 5000 413827 ns/op http_test.BenchmarkClientServer 5000 392723 ns/op

Patch Set 1 #

Patch Set 2 : diff -r e381c175229d https://go.googlecode.com/hg/ #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	src/pkg/http/serve_test.go	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 10 months ago (2011-05-27 22:39:28 UTC) #1

LGTM could you please run the benchmark on gopher (you could just copy the gotest-generated ...

13 years, 10 months ago (2011-05-27 23:10:16 UTC) #2

bradfitz

13 years, 10 months ago (2011-05-27 23:43:03 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=578140c93dd5 ***

http: client+server benchmark

baseline runs: (6g, gopher.mtv)

http_test.BenchmarkClientServer  5000  412588 ns/op
http_test.BenchmarkClientServer  5000  403346 ns/op
http_test.BenchmarkClientServer  5000  413936 ns/op
http_test.BenchmarkClientServer  5000  410287 ns/op
http_test.BenchmarkClientServer  5000  388037 ns/op
http_test.BenchmarkClientServer  5000  405545 ns/op
http_test.BenchmarkClientServer  5000  405179 ns/op
http_test.BenchmarkClientServer  5000  413827 ns/op
http_test.BenchmarkClientServer  5000  392723 ns/op

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4515155

Expand All Messages | Collapse All Messages