Issue 4515139: code review 4515139: ld: add -w to disable dwarf, make errors obviously from...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515139: code review 4515139: ld: add -w to disable dwarf, make errors obviously from... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years ago by rsc

Modified:
14 years ago

Reviewers:

CC:
lvd, golang-dev

Visibility:
Public.

Description

ld: add -w to disable dwarf, make errors obviously from dwarf Reenable dwarf output on Mac. Was writing headers but no actual dwarf data. Fixes issue 1877 (accidentally). Workaround for issue 1878.

Patch Set 1 #

Patch Set 2 : diff -r 99a520c00dcf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 99a520c00dcf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 99a520c00dcf https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 99a520c00dcf https://go.googlecode.com/hg/ #

Created: 14 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -16 lines)			Patch
M	src/cmd/6l/asm.c	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/8l/asm.c	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/cmd/ld/dwarf.c	View	1 2	18 chunks	+33 lines, -16 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello lvd (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years ago (2011-05-25 12:20:08 UTC) #1

rsc

14 years ago (2011-05-25 12:25:42 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=4766925f012c ***

ld: add -w to disable dwarf, make errors obviously from dwarf

Reenable dwarf output on Mac.
Was writing headers but no actual dwarf data.

Fixes issue 1877 (accidentally).
Workaround for issue 1878.

R=lvd
CC=golang-dev
http://codereview.appspot.com/4515139

Expand All Messages | Collapse All Messages