Issue 4515109: New JS pipeline now respects unknown feature

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515109: New JS pipeline now respects unknown feature

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by mhermanto

Modified:
14 years, 10 months ago

Reviewers:
zhoresh

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

This is what the old pipeline does.

Patch Set 1 : Update patch #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+15 lines, -40 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/AddJslLoadedVariableProcessor.java	View	5 chunks	+3 lines, -14 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/GetJsContentProcessor.java	View	5 chunks	+4 lines, -20 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/AddJslLoadedVariableProcessorTest.java	View	4 chunks	+4 lines, -4 lines	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/js/GetJsContentProcessorTest.java	View	3 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

zhoresh

LGTM But it will nice to give some feedback to user about missing features - ...

14 years, 10 months ago (2011-05-18 22:12:55 UTC) #3

mhermanto

14 years, 10 months ago (2011-05-18 22:17:17 UTC) #4

Done.

On Wed, May 18, 2011 at 3:12 PM, <zhoresh@gmail.com> wrote:

> LGTM
> But it will nice to give some feedback to user about missing features -
> maybe a warning in a comment.
> At least put a todo for that.
>
>
>
> http://codereview.appspot.com/4515109/
>

Expand All Messages | Collapse All Messages