Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 4515055: Have gadgets.rpc use the new XHTML-based iframe creation

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by mhermanto
Modified:
11 years, 2 months ago
Reviewers:
fargo
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Patch Set 1 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
features/src/main/javascript/features/rpc/feature.xml View 1 chunk +2 lines, -1 line 0 comments Download
features/src/main/javascript/features/rpc/rpc.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
mhermanto
14 years, 10 months ago (2011-05-10 02:37:41 UTC) #1
mhermanto
Update
14 years, 10 months ago (2011-05-10 02:39:04 UTC) #2
fargo
14 years, 10 months ago (2011-05-10 02:40:50 UTC) #3
LGTM

But let's be sure to change that dep to core.util.dom ASAP.

On Mon, May 9, 2011 at 7:39 PM, <mhermanto@gmail.com> wrote:

> Update
>
>
> http://codereview.appspot.com/4515055/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b