Issue 4515055: Have gadgets.rpc use the new XHTML-based iframe creation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4515055: Have gadgets.rpc use the new XHTML-based iframe creation

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by mhermanto

Modified:
11 years, 2 months ago

Reviewers:
fargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Patch Set 1 : Update #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
		features/src/main/javascript/features/rpc/feature.xml	View		1 chunk	+2 lines, -1 line	0 comments	Download
		features/src/main/javascript/features/rpc/rpc.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fargo

14 years, 10 months ago (2011-05-10 02:40:50 UTC) #3

LGTM

But let's be sure to change that dep to core.util.dom ASAP.

On Mon, May 9, 2011 at 7:39 PM, <mhermanto@gmail.com> wrote:

> Update
>
>
> http://codereview.appspot.com/4515055/
>

Expand All Messages | Collapse All Messages