code review 4511041: ld: fix alignment of rodata section on Plan 9

ld: fix alignment of rodata section on Plan 9

This was causing a panic in the reflect package
since type.* pointers with their low bits set are
assumed to have certain flags set that disallow
the use of reflection.

Thanks to Pavel and Taru for help tracking down
this bug.

[ality, 2011-05-07 12:21:18]

Hello rsc, paulzhol, taruti (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[paulzhol, 2011-05-07 15:53:55]

http://codereview.appspot.com/4511041/diff/3001/src/cmd/ld/data.c
File src/cmd/ld/data.c (left):

http://codereview.appspot.com/4511041/diff/3001/src/cmd/ld/data.c#oldcode902
src/cmd/ld/data.c:902: if(HEADTYPE == Hplan9x32) {
the curly braces can go away.

[rsc, 2011-05-11 15:58:32]

LGTM

please drop the braces and hg mail

[ality, 2011-05-11 21:14:51]

Hello rsc, paulzhol, taruti (cc: golang-dev@googlegroups.com),

Please take another look.

[ality, 2011-05-11 21:17:22]

Sorry about the delay. I've been busy.

Thanks,
  Anthony

[rsc, 2011-05-12 03:52:09]

*** Submitted as http://code.google.com/p/go/source/detail?r=09a28faa1555 ***

ld: fix alignment of rodata section on Plan 9

This was causing a panic in the reflect package
since type.* pointers with their low bits set are
assumed to have certain flags set that disallow
the use of reflection.

Thanks to Pavel and Taru for help tracking down
this bug.

R=rsc, paulzhol, taruti
CC=golang-dev
http://codereview.appspot.com/4511041

Committer: Russ Cox <rsc@golang.org>