Issue 45020044: Support binding to events

Issue 45020044: Support binding to events (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by rafaelw

Modified:
11 years, 3 months ago

Reviewers:
arv, sorvell, sjmiles

CC:
John Messerly, justin

Base URL:
https://github.com/Polymer/NodeBind.git@master

Visibility:
Public.

More Reviews

Description

Support binding to events R=arv BUG= Committed: https://github.com/Polymer/NodeBind/commit/5030c46

Patch Set 2 : cleanu #

Total comments: 8

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -0 lines)			Patch
	M	src/NodeBind.js	View	1	1 chunk	+39 lines, -0 lines	2 comments	Download
	M	tests/tests.js	View		1 chunk	+60 lines, -0 lines	6 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #2 manually as r5030c46 (presubmit successful).

11 years, 4 months ago (2013-12-22 01:48:08 UTC) #2

arv

Neat. LGTM https://codereview.appspot.com/45020044/diff/20001/src/NodeBind.js File src/NodeBind.js (right): https://codereview.appspot.com/45020044/diff/20001/src/NodeBind.js#newcode167 src/NodeBind.js:167: } ; https://codereview.appspot.com/45020044/diff/20001/tests/tests.js File tests/tests.js (right): https://codereview.appspot.com/45020044/diff/20001/tests/tests.js#newcode220 ...

11 years, 3 months ago (2014-01-03 16:57:39 UTC) #3

rafaelw

https://codereview.appspot.com/45020044/diff/20001/src/NodeBind.js File src/NodeBind.js (right): https://codereview.appspot.com/45020044/diff/20001/src/NodeBind.js#newcode167 src/NodeBind.js:167: } On 2014/01/03 16:57:40, arv wrote: > ; Done. ...

11 years, 3 months ago (2014-01-03 19:21:52 UTC) #4

arv

Doesn't this cause conflicts with polymer? In polymer we use event delegation.

11 years, 3 months ago (2014-01-06 15:39:21 UTC) #5

sorvell

11 years, 3 months ago (2014-01-06 15:45:32 UTC) #6

Polymer used to do that but the current implementation is very similar to
what's done here. There are a couple minor wrinkles, but Polymer will
probably migrate to use Node.bind's support for declarative events directly.

On Mon, Jan 6, 2014 at 7:39 AM, <arv@chromium.org> wrote:

> Doesn't this cause conflicts with polymer? In polymer we use event
> delegation.
>
> https://codereview.appspot.com/45020044/
>

Expand All Messages | Collapse All Messages