Issue 4483043: Change loaded features syntax

Issue 4483043: Change loaded features syntax (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 8 months ago by mhermanto

Modified:
14 years, 8 months ago

Reviewers:
johnfargo, fargo

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

from: /gadgets/js/x:y.js?loaded=a:b to: /gadgets/js/x:y!a:b.js

Patch Set 1 : update #

Total comments: 1

Created: 14 years, 8 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+10 lines, -13 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java	View	2 chunks	+8 lines, -10 lines	1 comment	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriCommon.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultJsUriManagerTest.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

johnfargo

http://codereview.appspot.com/4483043/diff/6002/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java (right): http://codereview.appspot.com/4483043/diff/6002/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java#newcode179 java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java:179: Collection<String> have = getJsLibs(splits.length >= 2 ? splits[1] : ...

14 years, 8 months ago (2011-05-04 23:15:34 UTC) #3

mhermanto

On Wed, May 4, 2011 at 4:15 PM, <johnfargo@gmail.com> wrote: > > > http://codereview.appspot.com/4483043/diff/6002/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java > ...

14 years, 8 months ago (2011-05-04 23:20:05 UTC) #4

johnfargo

14 years, 8 months ago (2011-05-05 00:20:08 UTC) #5

LGTM

sgtm

On Wed, May 4, 2011 at 4:19 PM, Michael Hermanto <mhermanto@gmail.com>wrote:

>
>
> On Wed, May 4, 2011 at 4:15 PM, <johnfargo@gmail.com> wrote:
>
>>
>>
>>
http://codereview.appspot.com/4483043/diff/6002/java/gadgets/src/main/java/or...
>> File
>>
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java
>> (right):
>>
>>
>>
http://codereview.appspot.com/4483043/diff/6002/java/gadgets/src/main/java/or...
>>
>>
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java:179:
>> Collection<String> have = getJsLibs(splits.length >= 2 ? splits[1] :
>> "");
>> potentially of value to support &loaded while ppl transition?
>
>
> AFAIK, no-one uses this now. I'll take the responsibility to migrate people
> here.
>
>
>>
>> http://codereview.appspot.com/4483043/
>>
>
>

Expand All Messages | Collapse All Messages