Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(152)

Issue 4478042: Support localization of feature parameters

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 8 months ago by igor1x
Modified:
14 years, 8 months ago
Reviewers:
dev, zhoresh
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Added support for localization of feature parameters. Modified ModulePrefs and Feature classes, and added extra testing to the ModulePrefsTest class. Incorporated Ziv Horesh's suggestion that a new copy of the feature be created and cached. https://issues.apache.org/jira/browse/SHINDIG-1523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/Feature.java View 1 chunk +17 lines, -0 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/spec/ModulePrefs.java View 1 chunk +15 lines, -1 line 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/spec/ModulePrefsTest.java View 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3
igor1x
14 years, 8 months ago (2011-05-04 18:42:11 UTC) #1
zhoresh
lgtm, thanks!
14 years, 8 months ago (2011-05-05 17:17:58 UTC) #2
zhoresh
14 years, 8 months ago (2011-05-05 17:23:58 UTC) #3
Committed to r1099881
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b